<p>In <a href="https://github.com/mlpack/mlpack/pull/694#discussion_r69373654">src/mlpack/core/data/dataset_info.hpp</a>:</p>
<pre style='color:#555'>&gt; @@ -37,7 +37,7 @@ class DatasetMapper
&gt;     */
&gt;    DatasetMapper(const size_t dimensionality = 0);
&gt;  
&gt; -  DatasetMapper(MapPolicy policy, const size_t dimensionality = 0);
&gt; +  DatasetMapper(PolicyType&amp; policy, const size_t dimensionality = 0);
</pre>
<p>Do you need the ability of implicit conversion?If not, maybe we could make the constructor as explicit?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/694/files/87d8d46396a42a4cd491b32be4f17e8582c9223d..de0b2dbba2422296d801e7aa60dc2ed06091ae1a#r69373654">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe/AJ4bFJ7wclz4MYhAHWqjY5RlN630hFeJks5qRgNBgaJpZM4I07W-">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFGFhAv3KbkPHmGr78krOpnZlrWlmks5qRgNBgaJpZM4I07W-.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/mlpack/mlpack/pull/694/files/87d8d46396a42a4cd491b32be4f17e8582c9223d..de0b2dbba2422296d801e7aa60dc2ed06091ae1a#r69373654"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>