[mlpack-git] [mlpack/mlpack] Use move semantics to set a given reference tree in NeighborSearch class. (#765)

MarcosPividori notifications at github.com
Mon Aug 29 17:20:12 EDT 2016

> @@ -33,6 +33,12 @@ class TreeTraits<CoverTree<MetricType, StatisticType, MatType, RootPointPolicy>>
>    static const bool HasOverlappingChildren = true;
>    /**
> +   * Cover trees do have self-children, so points can be included in more than
> +   * one node.
> +   */
> +  static const bool HasDuplicatedPoints = true;

Hi @rcurtin ,
In fact we use another flag: `UniqueNumDescendants`,  to recognize the case where `NumDescendants()` includes repeated points.
The flag `HasDuplicatedPoints` is not used anywhere, in fact I orginally removed it but you suggested in https://github.com/mlpack/mlpack/pull/743#discussion_r73456217 that you would like to keep it for the future.
Would you prefer to remove it or keeping it for future use?

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160829/6444672e/attachment.html>

More information about the mlpack-git mailing list