[mlpack-git] [mlpack/mlpack] Use move semantics to set a given reference tree in NeighborSearch class. (#765)

[Ryan Curtin]

> @@ -33,6 +33,12 @@ class TreeTraits<CoverTree<MetricType, StatisticType, MatType, RootPointPolicy>>
>    static const bool HasOverlappingChildren = true;
>  
>    /**
> +   * Cover trees do have self-children, so points can be included in more than
> +   * one node.
> +   */
> +  static const bool HasDuplicatedPoints = true;

I think that `HasDuplicatedPoints` was meant to encode whether or not `NumDescendants()` accounted for each point uniquely.  In the case of the cover tree, even though points are duplicated, the properties of the self-child (and the fact that it only holds one point) mean that we can correctly calculate the number of unique descendants and return them with `Descendant()`.  So maybe our name `HasDuplicatedPoints` should be changed somehow, but either way, I think that this value should be `false`.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/765/files/8bf2e5c7dbcf3e9c9db6339d371fe17ba046ea75#r76685478
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160829/a22db7a0/attachment.html>