<p>In <a href="https://github.com/mlpack/mlpack/pull/765#discussion_r76685478">src/mlpack/core/tree/cover_tree/traits.hpp</a>:</p>
<pre style='color:#555'>> @@ -33,6 +33,12 @@ class TreeTraits<CoverTree<MetricType, StatisticType, MatType, RootPointPolicy>>
> static const bool HasOverlappingChildren = true;
>
> /**
> + * Cover trees do have self-children, so points can be included in more than
> + * one node.
> + */
> + static const bool HasDuplicatedPoints = true;
</pre>
<p>I think that <code>HasDuplicatedPoints</code> was meant to encode whether or not <code>NumDescendants()</code> accounted for each point uniquely. In the case of the cover tree, even though points are duplicated, the properties of the self-child (and the fact that it only holds one point) mean that we can correctly calculate the number of unique descendants and return them with <code>Descendant()</code>. So maybe our name <code>HasDuplicatedPoints</code> should be changed somehow, but either way, I think that this value should be <code>false</code>.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/765/files/8bf2e5c7dbcf3e9c9db6339d371fe17ba046ea75#r76685478">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJ4bFNNNj09ConLNzO7M1mmgCsTgLogyks5qk0dRgaJpZM4JoBeZ">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFKJwK7i9fqoihmR3If408vHZH_Noks5qk0dRgaJpZM4JoBeZ.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/mlpack/mlpack/pull/765/files/8bf2e5c7dbcf3e9c9db6339d371fe17ba046ea75#r76685478"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/mlpack/mlpack","title":"mlpack/mlpack","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/mlpack/mlpack"}},"updates":{"snippets":[{"icon":"PERSON","message":"@rcurtin in #765: I think that `HasDuplicatedPoints` was meant to encode whether or not `NumDescendants()` accounted for each point uniquely. In the case of the cover tree, even though points are duplicated, the properties of the self-child (and the fact that it only holds one point) mean that we can correctly calculate the number of unique descendants and return them with `Descendant()`. So maybe our name `HasDuplicatedPoints` should be changed somehow, but either way, I think that this value should be `false`."}],"action":{"name":"View Pull Request","url":"https://github.com/mlpack/mlpack/pull/765/files/8bf2e5c7dbcf3e9c9db6339d371fe17ba046ea75#r76685478"}}}</script>