[mlpack-git] [mlpack/mlpack] Universal B tree implementation (#746)

[lozhnikov]

> @@ -877,7 +879,43 @@ template<typename MetricType,
>           template<typename BoundMetricType, typename...> class BoundType,
>           template<typename SplitBoundType, typename SplitMatType>
>               class SplitType>
> +size_t BinarySpaceTree<MetricType, StatisticType, MatType, BoundType,
> +    SplitType>::PerformSplit(
> +    MatType& data,
> +    const size_t begin,
> +    const size_t count,
> +    const typename UBTreeSplit<BoundType<MetricType>,
> +                               MatType>::SplitInfo& splitInfo)
> +{
> +  return SplitType<BoundType<MetricType>, MatType>::PerformSplit(data, begin,
> +      count, splitInfo);
> +}

I thought about that. I don't like the current approach, but I think this is the most economical approach (i.e. it requires the least amount of code).

I am not sure that it is a good idea to add the function to the math namespace since it is used only in `BinarySpaceTree` (if I am not mistaken). Maybe it is better to add a file in the `binary_space_tree` directory (e.g. `perform_split.hpp`) and an extra namespace there (e.g. 'namespace split`). What do you think about that?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/746/files/f17843fc8e8ef2b1c4b04d572c521575f20a1f3c#r76269499
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160825/3ba78c6f/attachment.html>