<p>In <a href="https://github.com/mlpack/mlpack/pull/746#discussion_r76269499">src/mlpack/core/tree/binary_space_tree/binary_space_tree_impl.hpp</a>:</p>
<pre style='color:#555'>&gt; @@ -877,7 +879,43 @@ template&lt;typename MetricType,
&gt;           template&lt;typename BoundMetricType, typename...&gt; class BoundType,
&gt;           template&lt;typename SplitBoundType, typename SplitMatType&gt;
&gt;               class SplitType&gt;
&gt; +size_t BinarySpaceTree&lt;MetricType, StatisticType, MatType, BoundType,
&gt; +    SplitType&gt;::PerformSplit(
&gt; +    MatType&amp; data,
&gt; +    const size_t begin,
&gt; +    const size_t count,
&gt; +    const typename UBTreeSplit&lt;BoundType&lt;MetricType&gt;,
&gt; +                               MatType&gt;::SplitInfo&amp; splitInfo)
&gt; +{
&gt; +  return SplitType&lt;BoundType&lt;MetricType&gt;, MatType&gt;::PerformSplit(data, begin,
&gt; +      count, splitInfo);
&gt; +}
</pre>
<p>I thought about that. I don't like the current approach, but I think this is the most economical approach (i.e. it requires the least amount of code).</p>

<p>I am not sure that it is a good idea to add the function to the math namespace since it is used only in <code>BinarySpaceTree</code> (if I am not mistaken). Maybe it is better to add a file in the <code>binary_space_tree</code> directory (e.g. <code>perform_split.hpp</code>) and an extra namespace there (e.g. 'namespace split`). What do you think about that?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/746/files/f17843fc8e8ef2b1c4b04d572c521575f20a1f3c#r76269499">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJ4bFB5wF5k73GYVjz_FWHWoLn8dylfGks5qjbjOgaJpZM4JZrEi">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFIUYKrsLIjpqL5wU8DAVu77h3HyFks5qjbjOgaJpZM4JZrEi.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/mlpack/mlpack/pull/746/files/f17843fc8e8ef2b1c4b04d572c521575f20a1f3c#r76269499"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/mlpack/mlpack","title":"mlpack/mlpack","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/mlpack/mlpack"}},"updates":{"snippets":[{"icon":"PERSON","message":"@lozhnikov in #746: I thought about that. I don't like the current approach, but I think this is the most economical approach (i.e. it requires the least amount of code).\r\n\r\nI am not sure that it is a good idea to add the function to the math namespace since it is used only in `BinarySpaceTree` (if I am not mistaken). Maybe it is better to add a file in the `binary_space_tree` directory (e.g. `perform_split.hpp`) and an extra namespace there (e.g. 'namespace split`). What do you think about that?"}],"action":{"name":"View Pull Request","url":"https://github.com/mlpack/mlpack/pull/746/files/f17843fc8e8ef2b1c4b04d572c521575f20a1f3c#r76269499"}}}</script>