[mlpack-git] [mlpack/mlpack] General greedy traverser. (#762)

[Ryan Curtin]

> @@ -309,14 +412,21 @@ class NeighborSearch
>    //! Return the number of node combination scores during the last search.
>    size_t Scores() const { return scores; }
>  
> +  //! Access the search mode.
> +  NeighborSearchMode SearchMode() const { return searchMode; }
> +  //! Modify the search mode.
> +  void SetSearchMode(const NeighborSearchMode mode);

I think I'd prefer this to be `NeighborSearchMode& SearchMode()` instead of the way it is now, so it can operate the same way the other functions did.  I realize that this can cause some difficulty (this is similar to why you need `UpdateSearchMode()`), but I think we can resolve any actual problems from this by saying that calling `SingleMode()` or `Naive()` (until mlpack 3.0.0 when they are gone) will override whatever `SearchMode()` is set to.

Alternately, we remove `SearchMode()` and `SetSearchMode()` and add a `greedy` member and do the same thing that you are doing with `naive` and `singleMode`.  But I like that solution less.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/762/files/f8ddd58ece06362024944a6533f68074a6b27ef7#r75530833
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160819/0bb1620e/attachment.html>