<p>In <a href="https://github.com/mlpack/mlpack/pull/762#discussion_r75530833">src/mlpack/methods/neighbor_search/neighbor_search.hpp</a>:</p>
<pre style='color:#555'>> @@ -309,14 +412,21 @@ class NeighborSearch
> //! Return the number of node combination scores during the last search.
> size_t Scores() const { return scores; }
>
> + //! Access the search mode.
> + NeighborSearchMode SearchMode() const { return searchMode; }
> + //! Modify the search mode.
> + void SetSearchMode(const NeighborSearchMode mode);
</pre>
<p>I think I'd prefer this to be <code>NeighborSearchMode& SearchMode()</code> instead of the way it is now, so it can operate the same way the other functions did. I realize that this can cause some difficulty (this is similar to why you need <code>UpdateSearchMode()</code>), but I think we can resolve any actual problems from this by saying that calling <code>SingleMode()</code> or <code>Naive()</code> (until mlpack 3.0.0 when they are gone) will override whatever <code>SearchMode()</code> is set to.</p>
<p>Alternately, we remove <code>SearchMode()</code> and <code>SetSearchMode()</code> and add a <code>greedy</code> member and do the same thing that you are doing with <code>naive</code> and <code>singleMode</code>. But I like that solution less.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/762/files/f8ddd58ece06362024944a6533f68074a6b27ef7#r75530833">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJ4bFDlmGfnc0-h74NbPs7WsMOLqgqflks5qhfbigaJpZM4JlKcS">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFKA8rDoCM4dv2JUDLGf5BTUsLdVsks5qhfbigaJpZM4JlKcS.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/mlpack/mlpack/pull/762/files/f8ddd58ece06362024944a6533f68074a6b27ef7#r75530833"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/mlpack/mlpack","title":"mlpack/mlpack","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/mlpack/mlpack"}},"updates":{"snippets":[{"icon":"PERSON","message":"@rcurtin in #762: I think I'd prefer this to be `NeighborSearchMode\u0026 SearchMode()` instead of the way it is now, so it can operate the same way the other functions did. I realize that this can cause some difficulty (this is similar to why you need `UpdateSearchMode()`), but I think we can resolve any actual problems from this by saying that calling `SingleMode()` or `Naive()` (until mlpack 3.0.0 when they are gone) will override whatever `SearchMode()` is set to.\r\n\r\nAlternately, we remove `SearchMode()` and `SetSearchMode()` and add a `greedy` member and do the same thing that you are doing with `naive` and `singleMode`. But I like that solution less."}],"action":{"name":"View Pull Request","url":"https://github.com/mlpack/mlpack/pull/762/files/f8ddd58ece06362024944a6533f68074a6b27ef7#r75530833"}}}</script>