[mlpack-git] [mlpack/mlpack] fixes: convolve with correct weight slice, pad input in forward pass (#737)

[Nilay Jain]

> @@ -125,8 +131,10 @@ class ConvLayer
>          arma::Mat<eT> output;
>          BackwardConvolutionRule::Convolution(gy.slice(inMap), rotatedFilter,
>              output);
> -
> -        g.slice(outMap) += output;
> +        g.slice(outMap) += output.submat(rotatedFilter.n_rows / 2,

I didn't put an if there because if we don't put a padding the submat would take the whole matrix. But putting if makes that point explicit. Thanks.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/737/files/e8ef7f47ff7d398bd8a7a6982860294a5a468f68#r74700043
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160814/0df5745a/attachment-0001.html>