<p>In <a href="https://github.com/mlpack/mlpack/pull/737#discussion_r74700043">src/mlpack/methods/ann/layer/conv_layer.hpp</a>:</p>
<pre style='color:#555'>> @@ -125,8 +131,10 @@ class ConvLayer
> arma::Mat<eT> output;
> BackwardConvolutionRule::Convolution(gy.slice(inMap), rotatedFilter,
> output);
> -
> - g.slice(outMap) += output;
> + g.slice(outMap) += output.submat(rotatedFilter.n_rows / 2,
</pre>
<p>I didn't put an if there because if we don't put a padding the submat would take the whole matrix. But putting if makes that point explicit. Thanks.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/737/files/e8ef7f47ff7d398bd8a7a6982860294a5a468f68#r74700043">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJ4bFKBW4t5bwxkesNEFxAcKSUjXBlQtks5qfviUgaJpZM4JTpf7">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFEpJt_skmyST39_gm2c8ghGt2bIsks5qfviUgaJpZM4JTpf7.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/mlpack/mlpack/pull/737/files/e8ef7f47ff7d398bd8a7a6982860294a5a468f68#r74700043"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/mlpack/mlpack","title":"mlpack/mlpack","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/mlpack/mlpack"}},"updates":{"snippets":[{"icon":"PERSON","message":"@nilayjain in #737: I didn't put an if there because if we don't put a padding the submat would take the whole matrix. But putting if makes that point explicit. Thanks."}],"action":{"name":"View Pull Request","url":"https://github.com/mlpack/mlpack/pull/737/files/e8ef7f47ff7d398bd8a7a6982860294a5a468f68#r74700043"}}}</script>