[mlpack-git] [mlpack/mlpack] Modeling LSH For Performance Tuning (#749)

[Ryan Curtin]

> +                 const arma::mat& statistic);
> +
> +      /** 
> +       * Evaluate the statistic for a given dataset size.
> +       *
> +       * @param N - a new input size for which to evaluate the expected
> +       *     statistic.
> +       */
> +      double Predict(size_t N, size_t k) 
> +      { return alpha * std::pow(k, beta) * std::pow(N, gamma); };
> +
> +      //! Set the alpha parameter.
> +      void Alpha(double a) { alpha = a; };
> +
> +      //! Get the alpha parameter.
> +      double Alpha(void) { return alpha; };

No need to mark `void` here, that's implicit.  For the other functions, I might consider marking the parameters const (like `const size_t N` instead of `size_t N`) even though it does nothing at all.  At least in mlpack, input options are generally denoted with a const specifier.  You can go either way here, since like I said it does nothing at all.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/749/files/cdcb575826bfb3bd0ef4cafacf465435b3d6d144#r74688589
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160813/fa668ff3/attachment.html>