<p>In <a href="https://github.com/mlpack/mlpack/pull/749#discussion_r74688589">src/mlpack/methods/lsh_model/lshmodel.hpp</a>:</p>
<pre style='color:#555'>> + const arma::mat& statistic);
> +
> + /**
> + * Evaluate the statistic for a given dataset size.
> + *
> + * @param N - a new input size for which to evaluate the expected
> + * statistic.
> + */
> + double Predict(size_t N, size_t k)
> + { return alpha * std::pow(k, beta) * std::pow(N, gamma); };
> +
> + //! Set the alpha parameter.
> + void Alpha(double a) { alpha = a; };
> +
> + //! Get the alpha parameter.
> + double Alpha(void) { return alpha; };
</pre>
<p>No need to mark <code>void</code> here, that's implicit. For the other functions, I might consider marking the parameters const (like <code>const size_t N</code> instead of <code>size_t N</code>) even though it does nothing at all. At least in mlpack, input options are generally denoted with a const specifier. You can go either way here, since like I said it does nothing at all.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/749/files/cdcb575826bfb3bd0ef4cafacf465435b3d6d144#r74688589">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJ4bFJmloDozs-kK14_TUKPudFIopTR1ks5qfenYgaJpZM4JczVR">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFMbZ5hI_sWf_K9mGr6wKOalL9TaHks5qfenYgaJpZM4JczVR.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/mlpack/mlpack/pull/749/files/cdcb575826bfb3bd0ef4cafacf465435b3d6d144#r74688589"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/mlpack/mlpack","title":"mlpack/mlpack","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/mlpack/mlpack"}},"updates":{"snippets":[{"icon":"PERSON","message":"@rcurtin in #749: No need to mark `void` here, that's implicit. For the other functions, I might consider marking the parameters const (like `const size_t N` instead of `size_t N`) even though it does nothing at all. At least in mlpack, input options are generally denoted with a const specifier. You can go either way here, since like I said it does nothing at all."}],"action":{"name":"View Pull Request","url":"https://github.com/mlpack/mlpack/pull/749/files/cdcb575826bfb3bd0ef4cafacf465435b3d6d144#r74688589"}}}</script>