[mlpack-git] [mlpack/mlpack] Spill trees (#747)

[MarcosPividori]

> +  const StatisticType& Stat() const { return stat; }
> +  //! Return the statistic object for this node.
> +  StatisticType& Stat() { return stat; }
> +
> +  //! Return whether or not this node is a leaf (true if it has no children).
> +  bool IsLeaf() const;
> +
> +  //! Gets the left child of this node.
> +  SpillTree* Left() const { return left; }
> +  //! Modify the left child of this node.
> +  SpillTree*& Left() { return left; }
> +
> +  //! Gets the right child of this node.
> +  SpillTree* Right() const { return right; }
> +  //! Modify the right child of this node.
> +  SpillTree*& Right() { return right; }

I agree with @sumedhghaisas .  I think it is more intuitive to use `Right()` and `Left()` in the implementation of the tree's traversers (`SingleTreeTraverser` and `DualTreeTraverser`).
But of course, if you prefer, I can update them to use `Child(0)` and `Child(1)`.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/747/files/a71b57caa90311f5542180bc0553449c3691395d#r73819038
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160807/e84e9619/attachment.html>