<p>In <a href="https://github.com/mlpack/mlpack/pull/747#discussion_r73819038">src/mlpack/core/tree/spill_tree/spill_tree.hpp</a>:</p>
<pre style='color:#555'>> + const StatisticType& Stat() const { return stat; }
> + //! Return the statistic object for this node.
> + StatisticType& Stat() { return stat; }
> +
> + //! Return whether or not this node is a leaf (true if it has no children).
> + bool IsLeaf() const;
> +
> + //! Gets the left child of this node.
> + SpillTree* Left() const { return left; }
> + //! Modify the left child of this node.
> + SpillTree*& Left() { return left; }
> +
> + //! Gets the right child of this node.
> + SpillTree* Right() const { return right; }
> + //! Modify the right child of this node.
> + SpillTree*& Right() { return right; }
</pre>
<p>I agree with <a href="https://github.com/sumedhghaisas" class="user-mention">@sumedhghaisas</a> . I think it is more intuitive to use <code>Right()</code> and <code>Left()</code> in the implementation of the tree's traversers (<code>SingleTreeTraverser</code> and <code>DualTreeTraverser</code>).<br>
But of course, if you prefer, I can update them to use <code>Child(0)</code> and <code>Child(1)</code>.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/747/files/a71b57caa90311f5542180bc0553449c3691395d#r73819038">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJ4bFMo6DMJJ7Hdq8-S6QjjEkrrDpkOYks5qdqOKgaJpZM4JZzLU">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFGsGsDHSDcvYiguwlkG6sGn1QcNDks5qdqOKgaJpZM4JZzLU.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/mlpack/mlpack/pull/747/files/a71b57caa90311f5542180bc0553449c3691395d#r73819038"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/mlpack/mlpack","title":"mlpack/mlpack","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/modules/aws/aws-bg.jpg","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/mlpack/mlpack"}},"updates":{"snippets":[{"icon":"PERSON","message":"@MarcosPividori in #747: I agree with @sumedhghaisas . I think it is more intuitive to use `Right()` and `Left()` in the implementation of the tree's traversers (`SingleTreeTraverser` and `DualTreeTraverser`).\r\nBut of course, if you prefer, I can update them to use `Child(0)` and `Child(1)`."}],"action":{"name":"View Pull Request","url":"https://github.com/mlpack/mlpack/pull/747/files/a71b57caa90311f5542180bc0553449c3691395d#r73819038"}}}</script>