[mlpack-git] [mlpack/mlpack] QUIC-SVD fails if m=n. (#717)

[Ryan Curtin]

I believe that I've fixed this in 5bd1e7c; the issue was basically that the cosine nodes would not split at all when there were two points, so I changed the minimum number of points.  In addition, the nodes would not split properly when there were only two points: the code (and the original equations in the paper) would cause both points to be in the left child, leaving an empty right child (which caused a failure).

I also found a minor error in 0be5c05, which I fixed.  I added the test you suggested to `quic_svd_test.cpp`.

If my fix didn't work, please reopen and I'll try again. :)

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/issues/717#issuecomment-238107966
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160807/50d50473/attachment.html>