<p>I believe that I've fixed this in <a href="https://github.com/mlpack/mlpack/commit/5bd1e7cf7e0cdc545fe06aef98ce1a1f051b976c" class="commit-link"><tt>5bd1e7c</tt></a>; the issue was basically that the cosine nodes would not split at all when there were two points, so I changed the minimum number of points.  In addition, the nodes would not split properly when there were only two points: the code (and the original equations in the paper) would cause both points to be in the left child, leaving an empty right child (which caused a failure).</p>

<p>I also found a minor error in <a href="https://github.com/mlpack/mlpack/commit/0be5c054c6e94c5f1441f8483d8e5c0db8c9010c" class="commit-link"><tt>0be5c05</tt></a>, which I fixed.  I added the test you suggested to <code>quic_svd_test.cpp</code>.</p>

<p>If my fix didn't work, please reopen and I'll try again. :)</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/issues/717#issuecomment-238107966">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJ4bFJ3xaub_Im0fYBCh6Wz_H6NYwTDDks5qdkajgaJpZM4JHAzz">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFLQQKSFfyREAzGa8rXCmUVJpMCIXks5qdkajgaJpZM4JHAzz.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/mlpack/mlpack/issues/717#issuecomment-238107966"></link>
  <meta itemprop="name" content="View Issue"></meta>
</div>
<meta itemprop="description" content="View this Issue on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/mlpack/mlpack","title":"mlpack/mlpack","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/modules/aws/aws-bg.jpg","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/mlpack/mlpack"}},"updates":{"snippets":[{"icon":"PERSON","message":"@rcurtin in #717: I believe that I've fixed this in 5bd1e7c; the issue was basically that the cosine nodes would not split at all when there were two points, so I changed the minimum number of points.  In addition, the nodes would not split properly when there were only two points: the code (and the original equations in the paper) would cause both points to be in the left child, leaving an empty right child (which caused a failure).\r\n\r\nI also found a minor error in 0be5c05, which I fixed.  I added the test you suggested to `quic_svd_test.cpp`.\r\n\r\nIf my fix didn't work, please reopen and I'll try again. :)"}],"action":{"name":"View Issue","url":"https://github.com/mlpack/mlpack/issues/717#issuecomment-238107966"}}}</script>