[mlpack-git] [mlpack/mlpack] Refactor `RSModel` and `RAModel` to parallel `NSModel` and use `boost::variant` (#756)

Ryan Curtin notifications at github.com
Sat Aug 6 09:54:10 EDT 2016

In 86a9852, `NSModel` was refactored to clean up a lot of the duplicated code and instead use `boost::variant` plus the visitor paradigm.  We should also apply these changes to `RSModel` and `RAModel`.

A good place to start here would be to look at the changes in 86a9852, and apply them to the very similar classes `RSModel` for range searching and `RAModel` for rank-approximate nearest neighbor search.

`NSModel` can be found in `src/mlpack/methods/neighbor_search/ns_model.hpp` and `src/mlpack/methods/neighbor_search/ns_model_impl.hpp`.
`RSModel` can be found in `src/mlpack/methods/range_search/rs_model.hpp` and `src/mlpack/methods/range_search/rs_model_impl.hpp`.
`RAModel` can be found in `src/mlpack/methods/rann/ra_model.hpp` and `src/mlpack/methods/rann/ra_model_impl.hpp`.

This could be a good issue for someone new who is looking to contribute their first PR.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160806/841197db/attachment-0001.html>

More information about the mlpack-git mailing list