<p>In <a href="https://github.com/mlpack/mlpack/commit/86a9852f19daf58e4ae5a3d3ca745deee43d8d16" class="commit-link"><tt>86a9852</tt></a>, <code>NSModel</code> was refactored to clean up a lot of the duplicated code and instead use <code>boost::variant</code> plus the visitor paradigm.  We should also apply these changes to <code>RSModel</code> and <code>RAModel</code>.</p>

<p>A good place to start here would be to look at the changes in <a href="https://github.com/mlpack/mlpack/commit/86a9852f19daf58e4ae5a3d3ca745deee43d8d16" class="commit-link"><tt>86a9852</tt></a>, and apply them to the very similar classes <code>RSModel</code> for range searching and <code>RAModel</code> for rank-approximate nearest neighbor search.</p>

<p><code>NSModel</code> can be found in <code>src/mlpack/methods/neighbor_search/ns_model.hpp</code> and <code>src/mlpack/methods/neighbor_search/ns_model_impl.hpp</code>.<br>
<code>RSModel</code> can be found in <code>src/mlpack/methods/range_search/rs_model.hpp</code> and <code>src/mlpack/methods/range_search/rs_model_impl.hpp</code>.<br>
<code>RAModel</code> can be found in <code>src/mlpack/methods/rann/ra_model.hpp</code> and <code>src/mlpack/methods/rann/ra_model_impl.hpp</code>.</p>

<p>This could be a good issue for someone new who is looking to contribute their first PR.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/issues/756">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJ4bFFwbXuVr3_hjmEKsEs4h0Eglacm0ks5qdJICgaJpZM4JeSJx">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFML4tiGuAJFMSNzc8Du76lmjoiGFks5qdJICgaJpZM4JeSJx.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/mlpack/mlpack/issues/756"></link>
  <meta itemprop="name" content="View Issue"></meta>
</div>
<meta itemprop="description" content="View this Issue on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/mlpack/mlpack","title":"mlpack/mlpack","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/modules/aws/aws-bg.jpg","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/mlpack/mlpack"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Refactor `RSModel` and `RAModel` to parallel `NSModel` and use `boost::variant` (#756)"}],"action":{"name":"View Issue","url":"https://github.com/mlpack/mlpack/issues/756"}}}</script>