[mlpack-git] [mlpack/mlpack] BUG: Misplaced parenthesis in comparison of absolute values (#628)

[ajjl]

The misplaced parenthesis around the comparison of the absolute
values of bandwidth and distance could cause erronus results. In
addition, this caused a "-Wabsolute-value" warning:

src/mlpack/core/kernels/epanechnikov_kernel.cpp:41:14:
warning: taking the absolute value of unsigned type 'bool' has no effect [-Wabsolute-value]
  } else if (std::abs(bandwidth > std::abs(distance)))
You can view, comment on, or merge this pull request online at:

  https://github.com/mlpack/mlpack/pull/628

-- Commit Summary --

  * BUG: Misplaced parenthesis in comparison of absolute values

-- File Changes --

    M src/mlpack/core/kernels/epanechnikov_kernel.cpp (2)

-- Patch Links --

https://github.com/mlpack/mlpack/pull/628.patch
https://github.com/mlpack/mlpack/pull/628.diff

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/pull/628
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20160421/9f38b23a/attachment.html>