<p>The misplaced parenthesis around the comparison of the absolute<br>
values of bandwidth and distance could cause erronus results. In<br>
addition, this caused a "-Wabsolute-value" warning:</p>
<p>src/mlpack/core/kernels/epanechnikov_kernel.cpp:41:14:<br>
warning: taking the absolute value of unsigned type 'bool' has no effect [-Wabsolute-value]<br>
} else if (std::abs(bandwidth > std::abs(distance)))</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/mlpack/mlpack/pull/628'>https://github.com/mlpack/mlpack/pull/628</a></p>
<h4>Commit Summary</h4>
<ul>
<li>BUG: Misplaced parenthesis in comparison of absolute values</li>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/mlpack/mlpack/pull/628/files#diff-0">src/mlpack/core/kernels/epanechnikov_kernel.cpp</a>
(2)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/mlpack/mlpack/pull/628.patch'>https://github.com/mlpack/mlpack/pull/628.patch</a></li>
<li><a href='https://github.com/mlpack/mlpack/pull/628.diff'>https://github.com/mlpack/mlpack/pull/628.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly or <a href="https://github.com/mlpack/mlpack/pull/628">view it on GitHub</a><img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFIcP2Iqvy29pvtdEX4Qv8sbn_6lmks5p5_OzgaJpZM4INHlD.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/mlpack/mlpack/pull/628"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>