[mlpack-git] master: Fix uninitialized values. (ce49a4b)

gitdub at big.cc.gt.atl.ga.us gitdub at big.cc.gt.atl.ga.us
Wed Oct 14 05:03:03 EDT 2015


Repository : https://github.com/mlpack/mlpack

On branch  : master
Link       : https://github.com/mlpack/mlpack/compare/81e72d4410ae417f7a8536bd3c61865e2f62c934...ce49a4b5f0b7d12d4955c09e45c69891a6f83e8a

>---------------------------------------------------------------

commit ce49a4b5f0b7d12d4955c09e45c69891a6f83e8a
Author: Ryan Curtin <ryan at ratml.org>
Date:   Wed Oct 14 05:02:35 2015 -0400

    Fix uninitialized values.


>---------------------------------------------------------------

ce49a4b5f0b7d12d4955c09e45c69891a6f83e8a
 src/mlpack/core/tree/rectangle_tree/rectangle_tree.hpp      | 2 +-
 src/mlpack/core/tree/rectangle_tree/rectangle_tree_impl.hpp | 7 ++++---
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/src/mlpack/core/tree/rectangle_tree/rectangle_tree.hpp b/src/mlpack/core/tree/rectangle_tree/rectangle_tree.hpp
index ff3b2ef..2d60f39 100644
--- a/src/mlpack/core/tree/rectangle_tree/rectangle_tree.hpp
+++ b/src/mlpack/core/tree/rectangle_tree/rectangle_tree.hpp
@@ -56,7 +56,7 @@ class RectangleTree
     int lastDimension;
     std::vector<bool> history;
 
-    SplitHistoryStruct(int dim) : history(dim)
+    SplitHistoryStruct(int dim) : lastDimension(0), history(dim)
     {
       for (int i = 0; i < dim; i++)
         history[i] = false;
diff --git a/src/mlpack/core/tree/rectangle_tree/rectangle_tree_impl.hpp b/src/mlpack/core/tree/rectangle_tree/rectangle_tree_impl.hpp
index 913bf4c..cbf870e 100644
--- a/src/mlpack/core/tree/rectangle_tree/rectangle_tree_impl.hpp
+++ b/src/mlpack/core/tree/rectangle_tree/rectangle_tree_impl.hpp
@@ -44,7 +44,8 @@ RectangleTree(const MatType& data,
     dataset(new MatType(data)),
     ownsDataset(true),
     points(maxLeafSize + 1), // Add one to make splitting the node simpler.
-    localDataset(new MatType(data.n_rows, static_cast<int> (maxLeafSize) + 1))
+    localDataset(new MatType(arma::zeros<MatType>(data.n_rows,
+                                                  maxLeafSize + 1)))
 {
   stat = StatisticType(*this);
 
@@ -79,8 +80,8 @@ RectangleTree(
     dataset(&parentNode->Dataset()),
     ownsDataset(false),
     points(maxLeafSize + 1), // Add one to make splitting the node simpler.
-    localDataset(new MatType(static_cast<int> (parentNode->Bound().Dim()),
-                             static_cast<int> (maxLeafSize) + 1))
+    localDataset(new MatType(arma::zeros<MatType>(parentNode->Bound().Dim(),
+                                                  maxLeafSize + 1)))
 {
   stat = StatisticType(*this);
 }



More information about the mlpack-git mailing list