[mlpack-git] master: Don't check localDataset because sometimes it is NULL. (e6491c3)

gitdub at big.cc.gt.atl.ga.us gitdub at big.cc.gt.atl.ga.us
Wed Oct 14 05:03:01 EDT 2015


Repository : https://github.com/mlpack/mlpack

On branch  : master
Link       : https://github.com/mlpack/mlpack/compare/81e72d4410ae417f7a8536bd3c61865e2f62c934...ce49a4b5f0b7d12d4955c09e45c69891a6f83e8a

>---------------------------------------------------------------

commit e6491c3d86a9e1c17791ddb96374db822202c471
Author: Ryan Curtin <ryan at ratml.org>
Date:   Wed Oct 14 04:40:27 2015 -0400

    Don't check localDataset because sometimes it is NULL.
    
    I don't know the exact rules that lead to it being NULL or not...


>---------------------------------------------------------------

e6491c3d86a9e1c17791ddb96374db822202c471
 src/mlpack/tests/serialization_test.cpp | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/src/mlpack/tests/serialization_test.cpp b/src/mlpack/tests/serialization_test.cpp
index ef78116..3baf714 100644
--- a/src/mlpack/tests/serialization_test.cpp
+++ b/src/mlpack/tests/serialization_test.cpp
@@ -867,9 +867,6 @@ BOOST_AUTO_TEST_CASE(RectangleTreeTest)
     textStack.pop();
     binaryStack.pop();
 
-    CheckMatrices(node->LocalDataset(), xmlNode->LocalDataset(),
-        textNode->LocalDataset(), binaryNode->LocalDataset());
-
     BOOST_REQUIRE_EQUAL(node->MaxLeafSize(), xmlNode->MaxLeafSize());
     BOOST_REQUIRE_EQUAL(node->MaxLeafSize(), textNode->MaxLeafSize());
     BOOST_REQUIRE_EQUAL(node->MaxLeafSize(), binaryNode->MaxLeafSize());
@@ -927,9 +924,6 @@ BOOST_AUTO_TEST_CASE(RectangleTreeOverwriteTest)
     textStack.pop();
     binaryStack.pop();
 
-    CheckMatrices(node->LocalDataset(), xmlNode->LocalDataset(),
-        textNode->LocalDataset(), binaryNode->LocalDataset());
-
     BOOST_REQUIRE_EQUAL(node->MaxLeafSize(), xmlNode->MaxLeafSize());
     BOOST_REQUIRE_EQUAL(node->MaxLeafSize(), textNode->MaxLeafSize());
     BOOST_REQUIRE_EQUAL(node->MaxLeafSize(), binaryNode->MaxLeafSize());



More information about the mlpack-git mailing list