[mlpack-git] [mlpack] matrix_completion_impl.hpp should be .cpp or have its functions inlined (#381)

[Ryan Curtin]

I was poking through the matrix completion code when I noticed that `matrix_completion_impl.hpp` is full of non-templatized functions that aren't marked `inline`.  This can be a problem if there are two separate compilation units that depend on `MatrixCompletion`; then there will be multiply-defined linker errors.

There are two possible ways to go, and both are easy: either we explicitly mark each function in `matrix_completion_impl.hpp` as `inline` so that the compiler doesn't provide symbols for the functions in separate compilation units, or we move `matrix_completion_impl.hpp` to `matrix_completion.cpp`.

But since I didn't write the code, I thought I'd open this issue so that you (@stephentu) could let me know what you want to do, and then either you can do it or I can do it, whatever, it's easy.  I figured if I waited until you showed up in IRC, I'd forget.  Hence the issue. :)

---
Reply to this email directly or view it on GitHub:
https://github.com/mlpack/mlpack/issues/381
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.cc.gatech.edu/pipermail/mlpack-git/attachments/20150113/7fde09b6/attachment.html>