[mlpack-svn] [MLPACK] #327: PCA Module Improvement

[MLPACK Trac]

#327: PCA Module Improvement
----------------------------+-----------------------------------------------
  Reporter:  siddharth.950  |        Owner:  birm    
      Type:  defect         |       Status:  accepted
  Priority:  major          |    Milestone:          
 Component:  mlpack         |   Resolution:          
  Keywords:                 |     Blocking:          
Blocked By:                 |  
----------------------------+-----------------------------------------------

Comment (by siddharth.950):

 The implementation seems correct to me. One change that I would recommend
 is removing the abs() on 'check' on line 41, it is theoretically
 incorrect. As far as the running time is concerned, I would expect it to
 be slower. That is because you have set the tolerance way too small. In
 the paper, they have used a tolerance of 0.01. Also, instead of saying
 'slower' or 'not matching up to the standard methods', it would be great
 if you could post the actual results :). I would suggest you to compare
 the implementations on a bigger dataset, of the dimensions mentioned in
 the paper. Hope that helps.

-- 
Ticket URL: <http://trac.research.cc.gatech.edu/fastlab/ticket/327#comment:5>
MLPACK <www.fast-lab.org>
MLPACK is an intuitive, fast, and scalable C++ machine learning library developed at Georgia Tech.