<p>Hi <a href="https://github.com/rcurtin" class="user-mention">@rcurtin</a> <br>
I am unable to figure out a fix for the memory leak. The newly added <code>FastMKS<>::Train(Tree&)</code> and <code>FastMKS<>::Train(Tree&&)</code> functions are causing the trouble.</p>
<p>This is snippet of the Valgrind output for <code>FastMKSModelLinearTest</code>: </p>
<pre><code>==7259== 1 bytes in 1 blocks are definitely lost in loss record 1 of 5
==7259== at 0x4C2B1C7: operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==7259== by 0xBF01BB: mlpack::fastmks::FastMKS<mlpack::kernel::LinearKernel, arma::Mat<double>, mlpack::tree::StandardCoverTree>::FastMKS(bool, bool) (in /home/kanodia/mlpack/build/bin/mlpack_test)
==7259== by 0xBF1BCF: void mlpack::fastmks::FastMKSModel::BuildModel<mlpack::kernel::LinearKernel>(arma::Mat<double> const&, mlpack::kernel::LinearKernel&, bool, bool, double) (in /home/kanodia/mlpack/build/bin/mlpack_test)
==7259== by 0xBBFBBC: FastMKSTest::FastMKSModelLinearTest::test_method() (in /home/kanodia/mlpack/build/bin/mlpack_test)
==7259== by 0xBC1B0D: FastMKSTest::FastMKSModelLinearTest_invoker() (in /home/kanodia/mlpack/build/bin/mlpack_test)
==7259== by 0xA05C56: boost::unit_test::ut_detail::callback0_impl_t<boost::unit_test::ut_detail::unused, void (*)()>::invoke() (in /home/kanodia/mlpack/build/bin/mlpack_test)
==7259== by 0x58CC520: ??? (in /usr/lib/x86_64-linux-gnu/libboost_unit_test_framework.so.1.55.0)
==7259== by 0x58A863D: boost::execution_monitor::catch_signals(boost::unit_test::callback0<int> const&) (in /usr/lib/x86_64-linux-gnu/libboost_unit_test_framework.so.1.55.0)
==7259== by 0x58A8F3A: boost::execution_monitor::execute(boost::unit_test::callback0<int> const&) (in /usr/lib/x86_64-linux-gnu/libboost_unit_test_framework.so.1.55.0)
==7259== by 0x58CC693: boost::unit_test::unit_test_monitor_t::execute_and_translate(boost::unit_test::test_case const&) (in /usr/lib/x86_64-linux-gnu/libboost_unit_test_framework.so.1.55.0)
==7259== by 0x58B7600: boost::unit_test::framework_impl::visit(boost::unit_test::test_case const&) (in /usr/lib/x86_64-linux-gnu/libboost_unit_test_framework.so.1.55.0)
==7259== by 0x58E9E82: boost::unit_test::traverse_test_tree(boost::unit_test::test_suite const&, boost::unit_test::test_tree_visitor&) (in /usr/lib/x86_64-linux-gnu/libboost_unit_test_framework.so.1.55.0)
</code></pre>
<pre><code>==7259== LEAK SUMMARY:
==7259== definitely lost: 3 bytes in 3 blocks
==7259== indirectly lost: 0 bytes in 0 blocks
==7259== possibly lost: 0 bytes in 0 blocks
==7259== still reachable: 72,712 bytes in 2 blocks
==7259== suppressed: 0 bytes in 0 blocks
==7259== Reachable blocks (those to which a pointer was found) are not shown.
==7259== To see them, rerun with: --leak-check=full --show-reachable=yes
==7259==
==7259== For counts of detected and suppressed errors, rerun with: -v
==7259== ERROR SUMMARY: 3 errors from 3 contexts (suppressed: 2 from 2)
</code></pre>
<p>Do take a look whenever you find time.<br>
Thank you</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/799#issuecomment-257859103">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJ4bFOmt1RkZ_LNfTDUeiQjQ4-0AXZ2sks5q6ItQgaJpZM4KPMkZ">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFP8uFKFpclOjymZf2c2EcoV6rjM3ks5q6ItQgaJpZM4KPMkZ.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/mlpack/mlpack/pull/799#issuecomment-257859103"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/mlpack/mlpack","title":"mlpack/mlpack","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/mlpack/mlpack"}},"updates":{"snippets":[{"icon":"PERSON","message":"@akanuraj200 in #799: Hi @rcurtin \r\nI am unable to figure out a fix for the memory leak. The newly added `FastMKS\u003c\u003e::Train(Tree\u0026)` and `FastMKS\u003c\u003e::Train(Tree\u0026\u0026)` functions are causing the trouble.\r\n\r\nThis is snippet of the Valgrind output for `FastMKSModelLinearTest`: \r\n```\r\n==7259== 1 bytes in 1 blocks are definitely lost in loss record 1 of 5\r\n==7259== at 0x4C2B1C7: operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)\r\n==7259== by 0xBF01BB: mlpack::fastmks::FastMKS\u003cmlpack::kernel::LinearKernel, arma::Mat\u003cdouble\u003e, mlpack::tree::StandardCoverTree\u003e::FastMKS(bool, bool) (in /home/kanodia/mlpack/build/bin/mlpack_test)\r\n==7259== by 0xBF1BCF: void mlpack::fastmks::FastMKSModel::BuildModel\u003cmlpack::kernel::LinearKernel\u003e(arma::Mat\u003cdouble\u003e const\u0026, mlpack::kernel::LinearKernel\u0026, bool, bool, double) (in /home/kanodia/mlpack/build/bin/mlpack_test)\r\n==7259== by 0xBBFBBC: FastMKSTest::FastMKSModelLinearTest::test_method() (in /home/kanodia/mlpack/build/bin/mlpack_test)\r\n==7259== by 0xBC1B0D: FastMKSTest::FastMKSModelLinearTest_invoker() (in /home/kanodia/mlpack/build/bin/mlpack_test)\r\n==7259== by 0xA05C56: boost::unit_test::ut_detail::callback0_impl_t\u003cboost::unit_test::ut_detail::unused, void (*)()\u003e::invoke() (in /home/kanodia/mlpack/build/bin/mlpack_test)\r\n==7259== by 0x58CC520: ??? (in /usr/lib/x86_64-linux-gnu/libboost_unit_test_framework.so.1.55.0)\r\n==7259== by 0x58A863D: boost::execution_monitor::catch_signals(boost::unit_test::callback0\u003cint\u003e const\u0026) (in /usr/lib/x86_64-linux-gnu/libboost_unit_test_framework.so.1.55.0)\r\n==7259== by 0x58A8F3A: boost::execution_monitor::execute(boost::unit_test::callback0\u003cint\u003e const\u0026) (in /usr/lib/x86_64-linux-gnu/libboost_unit_test_framework.so.1.55.0)\r\n==7259== by 0x58CC693: boost::unit_test::unit_test_monitor_t::execute_and_translate(boost::unit_test::test_case const\u0026) (in /usr/lib/x86_64-linux-gnu/libboost_unit_test_framework.so.1.55.0)\r\n==7259== by 0x58B7600: boost::unit_test::framework_impl::visit(boost::unit_test::test_case const\u0026) (in /usr/lib/x86_64-linux-gnu/libboost_unit_test_framework.so.1.55.0)\r\n==7259== by 0x58E9E82: boost::unit_test::traverse_test_tree(boost::unit_test::test_suite const\u0026, boost::unit_test::test_tree_visitor\u0026) (in /usr/lib/x86_64-linux-gnu/libboost_unit_test_framework.so.1.55.0)\r\n```\r\n\r\n```\r\n==7259== LEAK SUMMARY:\r\n==7259== definitely lost: 3 bytes in 3 blocks\r\n==7259== indirectly lost: 0 bytes in 0 blocks\r\n==7259== possibly lost: 0 bytes in 0 blocks\r\n==7259== still reachable: 72,712 bytes in 2 blocks\r\n==7259== suppressed: 0 bytes in 0 blocks\r\n==7259== Reachable blocks (those to which a pointer was found) are not shown.\r\n==7259== To see them, rerun with: --leak-check=full --show-reachable=yes\r\n==7259== \r\n==7259== For counts of detected and suppressed errors, rerun with: -v\r\n==7259== ERROR SUMMARY: 3 errors from 3 contexts (suppressed: 2 from 2)\r\n```\r\nDo take a look whenever you find time.\r\nThank you"}],"action":{"name":"View Pull Request","url":"https://github.com/mlpack/mlpack/pull/799#issuecomment-257859103"}}}</script>