<p><b>@lozhnikov</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/mlpack/mlpack/pull/790#pullrequestreview-2512610">src/mlpack/core/tree/octree/octree_impl.hpp</a>:</p>
<pre style='color:#555'>&gt; +  }
+
+  return bestIndex;
+}
+
+template&lt;typename MetricType, typename StatisticType, typename MatType&gt;
+size_t Octree&lt;MetricType, StatisticType, MatType&gt;::GetNearestChild(
+    const Octree&amp; queryNode) const
+{
+  // It&#39;s possible that this could be improved by caching which children we have
+  // and which we don&#39;t, but for now this is just a brute force search.
+  ElemType bestDistance = DBL_MAX;
+  size_t bestIndex = NumChildren();
+  for (size_t i = 0; i &lt; NumChildren(); ++i)
+  {
+    const double dist = children[i]-&gt;MaxDistance(queryNode);
</pre>
<p>I think that should be <code>MinDistance()</code>, how do you think?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/790#pullrequestreview-2512610">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJ4bFDTI7YCcMESLSN6aWRmpfUVOES1-ks5qwPWggaJpZM4KFuuW">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFIZnvp1mImY_Vskd_19RAggmKJngks5qwPWggaJpZM4KFuuW.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/mlpack/mlpack/pull/790#pullrequestreview-2512610"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/mlpack/mlpack","title":"mlpack/mlpack","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/mlpack/mlpack"}},"updates":{"snippets":[{"icon":"PERSON","message":"@lozhnikov commented on #790"}],"action":{"name":"View Pull Request","url":"https://github.com/mlpack/mlpack/pull/790#pullrequestreview-2512610"}}}</script>