<p><b>@rcurtin</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/mlpack/mlpack/pull/792#pullrequestreview-2062190">src/mlpack/core/optimizers/gradient_descent/gradient_descent_impl.hpp</a>:</p>
<pre style='color:#555'>> + double overallObjective = function.Evaluate(iterate);
+ double lastObjective = DBL_MAX;
+
+ // Now iterate!
+ arma::vec gradient(iterate.n_cols);
+ for (size_t i = 1; i != maxIterations; ++i)
+ {
+ // Output current objective function.
+ Log::Info << "Gradient Descent: iteration " << i << ", objective "
+ << overallObjective << "." << std::endl;
+
+ if (std::isnan(overallObjective) || std::isinf(overallObjective))
+ {
+ Log::Warn << "Gradient Descent: converged to " << overallObjective
+ << "; terminating" << " with failure. Try a smaller step size?"
+ << std::endl;
</pre>
<p>Continued lines should be intended two tabs from the previous line, not one :)</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/792#pullrequestreview-2062190">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJ4bFGieAJsD4hVIrhzqEtQqmngIUJHpks5quxzUgaJpZM4KIN-_">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFM9CVwghVrhlKuTCoWLn7MkjZIpyks5quxzUgaJpZM4KIN-_.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/mlpack/mlpack/pull/792#pullrequestreview-2062190"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/mlpack/mlpack","title":"mlpack/mlpack","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/mlpack/mlpack"}},"updates":{"snippets":[{"icon":"PERSON","message":"@rcurtin commented on #792"}],"action":{"name":"View Pull Request","url":"https://github.com/mlpack/mlpack/pull/792#pullrequestreview-2062190"}}}</script>