<p><b>@lozhnikov</b> commented on this pull request.</p>

<p>I've taken a quick look at the code. The code looks fine except two very minor issues. I'll look more thoroughly later.</p><hr>

<p>In <a href="https://github.com/mlpack/mlpack/pull/790#pullrequestreview-1455123">src/mlpack/core/tree/octree/octree_impl.hpp</a>:</p>
<pre style='color:#555'>&gt; +    const VecType&amp; point,
+    typename boost::enable_if&lt;IsVector&lt;VecType&gt;&gt;::type*) const
+{
+  return bound.RangeDistance(point);
+}
+
+//! Serialize the tree.
+template&lt;typename MetricType, typename StatisticType, typename MatType&gt;
+template&lt;typename Archive&gt;
+void Octree&lt;MetricType, StatisticType, MatType&gt;::Serialize(
+    Archive&amp; ar,
+    const unsigned int /* version */)
+{
+  using data::CreateNVP;
+
+  // 
</pre>
<p>It seems you have forgotten to remove <code>//</code>:)</p>

<hr>

<p>In <a href="https://github.com/mlpack/mlpack/pull/790#pullrequestreview-1455123">src/mlpack/core/tree/octree/octree_impl.hpp</a>:</p>
<pre style='color:#555'>&gt; +template&lt;typename MetricType, typename StatisticType, typename MatType&gt;
+void Octree&lt;MetricType, StatisticType, MatType&gt;::SplitNode(
+    const arma::vec&amp; center,
+    const double width,
+    const size_t maxLeafSize)
+{
+  // No need to split if we have fewer than the maximum number of points in this
+  // node.
+  if (count &lt;= maxLeafSize)
+    return;
+
+  // We must split the dataset by sequentially creating each of the children.
+  // We do this in two steps: first we make a pass to count the number of points
+  // that will fall into each child; then in the second pass we rearrange the
+  // points and create the children.
+  arma::Col&lt;size_t&gt; childCounts(std::pow(2, dataset-&gt;n_rows),
</pre>
<p>I think that <code>((size_t) 2) &lt;&lt; dataset-&gt;n_rows</code> is better than <code>std::pow()</code>, how do you think?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/790#pullrequestreview-1455123">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJ4bFKSe2lxPIk3SlD1wqwdTrm6ckLILks5qtpgLgaJpZM4KFuuW">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFAAMrnJ63vsEKX-vdJND1wFGQd-uks5qtpgLgaJpZM4KFuuW.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/mlpack/mlpack/pull/790#pullrequestreview-1455123"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/mlpack/mlpack","title":"mlpack/mlpack","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/mlpack/mlpack"}},"updates":{"snippets":[{"icon":"PERSON","message":"@lozhnikov commented on #790"}],"action":{"name":"View Pull Request","url":"https://github.com/mlpack/mlpack/pull/790#pullrequestreview-1455123"}}}</script>