<p>In <a href="https://github.com/mlpack/mlpack/pull/775#discussion_r78216974">src/mlpack/core/util/cli.cpp</a>:</p>
<pre style='color:#555'>&gt; +    // Iterate over all the program_options, looking for duplicate parameters.
&gt; +    // If we find any, remove the duplicates.
&gt; +    for (unsigned int i = 0; i &lt; bpo.options.size(); i++)
&gt; +    {
&gt; +      for (unsigned int j = i + 1; j &lt; bpo.options.size(); j++)
&gt; +      {
&gt; +        if (bpo.options[i].string_key == bpo.options[j].string_key)
&gt; +        {
&gt; +          // If a duplicate is found, check to see if either one has a value.
&gt; +          if (bpo.options[i].value.size() == 0 &amp;&amp;
&gt; +              bpo.options[j].value.size() == 0)
&gt; +          {
&gt; +            // If neither has a value, consider it a duplicate flag and remove
&gt; +            // the duplicate. It&#39;s important to not break out of this loop
&gt; +            // because there might be another duplicate later on in the vector.
&gt; +            bpo.options.erase(bpo.options.begin() +  j);
</pre>
<p>I think, If we don't break, and we remove another duplicate later on in the vector, we could run into an index out of bounds error.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/775/files/67be651c4376feb8bac4f95630ab12fae553d6ec#r78216974">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJ4bFDweqw_-EcPto_M6wnFzJmlvMHUIks5qoZZGgaJpZM4J0IHP">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFEKw0ZIW6a6zhNzbOeGjWQW9Mmzfks5qoZZGgaJpZM4J0IHP.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/mlpack/mlpack/pull/775/files/67be651c4376feb8bac4f95630ab12fae553d6ec#r78216974"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/mlpack/mlpack","title":"mlpack/mlpack","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/mlpack/mlpack"}},"updates":{"snippets":[{"icon":"PERSON","message":"@zoq in #775: I think, If we don't break, and we remove another duplicate later on in the vector, we could run into an index out of bounds error."}],"action":{"name":"View Pull Request","url":"https://github.com/mlpack/mlpack/pull/775/files/67be651c4376feb8bac4f95630ab12fae553d6ec#r78216974"}}}</script>