<p>In <a href="https://github.com/mlpack/mlpack/pull/746#discussion_r76321604">src/mlpack/core/tree/cellbound_impl.hpp</a>:</p>
<pre style='color:#555'>&gt; +  // of hyperrectangles is restricted.
&gt; +  size_t numCorners = 0;
&gt; +  for (size_t pos = numEqualBits + 1; pos &lt; order * tmpHiAddress.n_elem; pos++)
&gt; +  {
&gt; +    size_t row = pos / order;
&gt; +    size_t bit = order - 1 - pos % order;
&gt; +
&gt; +    // This hyperrectangle is not contained entirely in the bound.
&gt; +    // So, the number of hyperrectangles should be increased.
&gt; +    if (tmpHiAddress[row] &amp; ((AddressElemType) 1 &lt;&lt; bit))
&gt; +      numCorners++;
&gt; +
&gt; +    // We ran out of the limit of hyperrectangles. In that case we enlare
&gt; +    // the last hyperrectangle.
&gt; +    if (numCorners &gt;= maxNumBounds / 2)
&gt; +      tmpHiAddress[row] |= ((AddressElemType) 1 &lt;&lt; bit);
</pre>
<p>yeah, I think if <code>maxNumBounds</code> is odd then we end up with <code>maxNumBounds - 1</code>. I think we can replace<br>
<code>if (numCorners &gt;= maxNumBounds / 2)</code><br>
by<br>
<code>if (numCorners &gt;= maxNumBounds - numBounds)</code> in <code>InitLowerBound()</code><br>
In that case we should document that <code>InitLowerBound()</code> should be called after<br>
<code>InitHighBound()</code>. But in that case the functions are non-symmetric.</p>

<p>Another way is to document that <code>maxNumBounds</code> should be even.</p>

<p>And another way is to make an extra pass and calculate <code>numCorners</code> for the lower bound and for the high bound. What do you think about these variants?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/746/files/f17843fc8e8ef2b1c4b04d572c521575f20a1f3c#r76321604">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJ4bFGREmve1yTcFx0yyHsDjZTxhjRCwks5qjf-ygaJpZM4JZrEi">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFO6yosh6GsLuoHXsNVYqQ2oIrF50ks5qjf-ygaJpZM4JZrEi.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/mlpack/mlpack/pull/746/files/f17843fc8e8ef2b1c4b04d572c521575f20a1f3c#r76321604"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/mlpack/mlpack","title":"mlpack/mlpack","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/mlpack/mlpack"}},"updates":{"snippets":[{"icon":"PERSON","message":"@lozhnikov in #746: yeah, I think if `maxNumBounds` is odd then we end up with `maxNumBounds - 1`. I think we can replace\r\n`if (numCorners \u003e= maxNumBounds / 2)`\r\nby\r\n`if (numCorners \u003e= maxNumBounds - numBounds)` in `InitLowerBound()`\r\nIn that case we should document that `InitLowerBound()` should be called after\r\n`InitHighBound()`. But in that case the functions are non-symmetric.\r\n\r\nAnother way is to document that `maxNumBounds` should be even.\r\n\r\nAnd another way is to make an extra pass and calculate `numCorners` for the lower bound and for the high bound. What do you think about these variants?"}],"action":{"name":"View Pull Request","url":"https://github.com/mlpack/mlpack/pull/746/files/f17843fc8e8ef2b1c4b04d572c521575f20a1f3c#r76321604"}}}</script>