<p>In <a href="https://github.com/mlpack/mlpack/pull/746#discussion_r76270200">src/mlpack/core/tree/binary_space_tree/binary_space_tree_impl.hpp</a>:</p>
<pre style='color:#555'>> @@ -877,7 +879,43 @@ template<typename MetricType,
> template<typename BoundMetricType, typename...> class BoundType,
> template<typename SplitBoundType, typename SplitMatType>
> class SplitType>
> +size_t BinarySpaceTree<MetricType, StatisticType, MatType, BoundType,
> + SplitType>::PerformSplit(
> + MatType& data,
> + const size_t begin,
> + const size_t count,
> + const typename UBTreeSplit<BoundType<MetricType>,
> + MatType>::SplitInfo& splitInfo)
> +{
> + return SplitType<BoundType<MetricType>, MatType>::PerformSplit(data, begin,
> + count, splitInfo);
> +}
</pre>
<p>Sure, that sounds good to me. I figured it might be ok in <code>math</code> since maybe somewhere else might use it someday, but I agree, maybe we shouldn't move it there until multiple places use it.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/746/files/f17843fc8e8ef2b1c4b04d572c521575f20a1f3c#r76270200">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJ4bFHobVG55IHSiA0-EwWgGA3xJd2KSks5qjbmegaJpZM4JZrEi">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFDVcfdAVOPBzIy2V6tlHD2LK-WnCks5qjbmegaJpZM4JZrEi.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/mlpack/mlpack/pull/746/files/f17843fc8e8ef2b1c4b04d572c521575f20a1f3c#r76270200"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/mlpack/mlpack","title":"mlpack/mlpack","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/mlpack/mlpack"}},"updates":{"snippets":[{"icon":"PERSON","message":"@rcurtin in #746: Sure, that sounds good to me. I figured it might be ok in `math` since maybe somewhere else might use it someday, but I agree, maybe we shouldn't move it there until multiple places use it."}],"action":{"name":"View Pull Request","url":"https://github.com/mlpack/mlpack/pull/746/files/f17843fc8e8ef2b1c4b04d572c521575f20a1f3c#r76270200"}}}</script
>