<p>Looks great, I think this is ready for merge, after the <code>PerformSplit()</code> refactoring and <code>NeedRearrangeDataset</code> removal.  If you'd like me to do either of those, let me know and I will.  I think I still have yet to find any bugs in any of your code. <g-emoji alias="+1" fallback-src="https://assets-cdn.github.com/images/icons/emoji/unicode/1f44d.png">👍</g-emoji></p>

<p>While going over this, I thought that the ordering of dimensions makes a difference for the performance of the tree, because of how the addresses are calculated.  So I wondered if ordering the dimensions in the address according to the variance of each dimension (or simply scaling the variances to 1) might help performance.  But I think that the UB tree is so much slower than the kd tree that it's not really worth investigating.  I thought it was an interesting idea to write down anyway though. :)</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/746#issuecomment-242506335">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJ4bFKe6LO5SJgixZQaTF2KyzJCq6eTEks5qjeqrgaJpZM4JZrEi">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFMlqLzp3REDrCyGbwKHt_cLkTqFkks5qjeqrgaJpZM4JZrEi.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/mlpack/mlpack/pull/746#issuecomment-242506335"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/mlpack/mlpack","title":"mlpack/mlpack","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/mlpack/mlpack"}},"updates":{"snippets":[{"icon":"PERSON","message":"@rcurtin in #746: Looks great, I think this is ready for merge, after the `PerformSplit()` refactoring and `NeedRearrangeDataset` removal.  If you'd like me to do either of those, let me know and I will.  I think I still have yet to find any bugs in any of your code. :+1:\r\n\r\nWhile going over this, I thought that the ordering of dimensions makes a difference for the performance of the tree, because of how the addresses are calculated.  So I wondered if ordering the dimensions in the address according to the variance of each dimension (or simply scaling the variances to 1) might help performance.  But I think that the UB tree is so much slower than the kd tree that it's not really worth investigating.  I thought it was an interesting idea to write down anyway though. :)"}],"action":{"name":"View Pull Request","url":"https://github.com/mlpack/mlpack/pull/746#issuecomment-242506335"}}}</script>