<p>In <a href="https://github.com/mlpack/mlpack/pull/746#discussion_r76252824">src/mlpack/core/tree/address.hpp</a>:</p>
<pre style='color:#555'>> + point(i) = std::numeric_limits<VecElemType>::lowest();
> + }
> + }
> +}
> +
> +/**
> + * Compare two addresses. The function returns 1 if the first address is greater
> + * than the second one, -1 if the first address is less than the second one,
> + * otherwise the function returns 0.
> + */
> +template<typename AddressType1, typename AddressType2>
> +int CompareAddresses(const AddressType1& addr1, const AddressType2& addr2)
> +{
> + static_assert(sizeof(typename AddressType1::elem_type) ==
> + sizeof(typename AddressType2::elem_type), "We aren't able to compare "
> + "adresses of distinct sizes");
</pre>
<p>I think that you meant to check here if the number of elements in each address was the same, but this only checks that the size of each type of element is the same. Should we require that the type of element (i.e. double, size_t, whatever) is exactly the same, instead of simply having the same size?</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/746/files/f17843fc8e8ef2b1c4b04d572c521575f20a1f3c#r76252824">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJ4bFMmRHoADyuHJg1yW0URLtLa69V4Lks5qjaXCgaJpZM4JZrEi">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFFmcu-IA2_K9SNqvx9QR4w-o6rp2ks5qjaXCgaJpZM4JZrEi.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/mlpack/mlpack/pull/746/files/f17843fc8e8ef2b1c4b04d572c521575f20a1f3c#r76252824"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/mlpack/mlpack","title":"mlpack/mlpack","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/mlpack/mlpack"}},"updates":{"snippets":[{"icon":"PERSON","message":"@rcurtin in #746: I think that you meant to check here if the number of elements in each address was the same, but this only checks that the size of each type of element is the same. Should we require that the type of element (i.e. double, size_t, whatever) is exactly the same, instead of simply having the same size?"}],"action":{"name":"View Pull Request","url":"https://github.com/mlpack/mlpack/pull/746/files/f17843fc8e8ef2b1c4b04d572c521575f20a1f3c#r76252824"}}}</script>