<p>Hi <a href="https://github.com/rcurtin" class="user-mention">@rcurtin</a> ,<br>
I have rebased on top of master. Also, I removed the <code>oldFromNew</code> parameter. Now, I adopt exactly the same approach than with previous method: <code>void Train(Tree* referenceTree)</code>  "when providing a reference tree, the points won't be mapped".<br>
So, I added two <code>Train()</code> methods:</p>

<pre><code>void Train(Tree&amp; referenceTree); // Copy the reference tree.
void Train(Tree&amp;&amp; referenceTree); // Move the reference tree.
</code></pre>

<p>What do you think?<br>
Thanks!</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/765#issuecomment-241867261">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJ4bFMa743bUTTBaWPWTBhAPAX6YloSrks5qi1f-gaJpZM4JoBeZ">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFO7GZ6FS3ImK_GFLO1M5VyDLiPfSks5qi1f-gaJpZM4JoBeZ.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/mlpack/mlpack/pull/765#issuecomment-241867261"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/mlpack/mlpack","title":"mlpack/mlpack","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/mlpack/mlpack"}},"updates":{"snippets":[{"icon":"PERSON","message":"@MarcosPividori in #765: Hi @rcurtin ,\r\nI have rebased on top of master. Also, I removed the `oldFromNew` parameter. Now, I adopt exactly the same approach than with previous method: `void Train(Tree* referenceTree)`  \"when providing a reference tree, the points won't be mapped\".\r\nSo, I added two `Train()` methods:\r\n```\r\nvoid Train(Tree\u0026 referenceTree); // Copy the reference tree.\r\nvoid Train(Tree\u0026\u0026 referenceTree); // Move the reference tree.\r\n```\r\nWhat do you think?\r\nThanks!"}],"action":{"name":"View Pull Request","url":"https://github.com/mlpack/mlpack/pull/765#issuecomment-241867261"}}}</script>