<p>In <a href="https://github.com/mlpack/mlpack/pull/762#discussion_r75584833">src/mlpack/methods/neighbor_search/neighbor_search.hpp</a>:</p>
<pre style='color:#555'>> @@ -309,14 +412,21 @@ class NeighborSearch
> //! Return the number of node combination scores during the last search.
> size_t Scores() const { return scores; }
>
> + //! Access the search mode.
> + NeighborSearchMode SearchMode() const { return searchMode; }
> + //! Modify the search mode.
> + void SetSearchMode(const NeighborSearchMode mode);
</pre>
<p><a href="https://github.com/rcurtin" class="user-mention">@rcurtin</a> <br>
Ok, I have updated the code. Now, you can only modify and access to the search mode through the booleans: <code>Naive()</code>, <code>SingleMode()</code> and <code>Greedy()</code>. (I removed <code>SearchMode()</code> and <code>SetSearchMode()</code>)<br>
For version <code>3.0.0</code> we can remove all of that flags, and instead use a new method <code>NeighborSearchMode& SearchMode()</code>.<br>
I have made a new PR in <a href="https://github.com/mlpack/mlpack/pull/768" class="issue-link js-issue-link" data-url="https://github.com/mlpack/mlpack/issues/768" data-id="172290486" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#768</a> to include these changes.<br>
I think everything is backward compatible now.<br>
Thanks,</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/762/files/f8ddd58ece06362024944a6533f68074a6b27ef7#r75584833">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJ4bFGM7tGT_knOVSJHABUax371rlY-sks5qh2wfgaJpZM4JlKcS">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFN1uU--T7_-SG0XLxyrDi9TLB4Cwks5qh2wfgaJpZM4JlKcS.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/mlpack/mlpack/pull/762/files/f8ddd58ece06362024944a6533f68074a6b27ef7#r75584833"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/mlpack/mlpack","title":"mlpack/mlpack","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/mlpack/mlpack"}},"updates":{"snippets":[{"icon":"PERSON","message":"@MarcosPividori in #762: @rcurtin \r\nOk, I have updated the code. Now, you can only modify and access to the search mode through the booleans: `Naive()`, `SingleMode()` and `Greedy()`. (I removed `SearchMode()` and `SetSearchMode()`)\r\nFor version `3.0.0` we can remove all of that flags, and instead use a new method `NeighborSearchMode\u0026 SearchMode()`.\r\nI have made a new PR in https://github.com/mlpack/mlpack/pull/768 to include these changes.\r\nI think everything is backward compatible now.\r\nThanks,\r\n"}],"action":{"name":"View Pull Request","url":"https://github.com/mlpack/mlpack/pull/762/files/f8ddd58ece06362024944a6533f68074a6b27ef7#r75584833"}}}</script>