<p>In <a href="https://github.com/mlpack/mlpack/pull/762#discussion_r75478487">src/mlpack/core/tree/greedy_single_tree_traverser_impl.hpp</a>:</p>
<pre style='color:#555'>&gt; +    RuleType&amp; rule) :
&gt; +    rule(rule),
&gt; +    numPrunes(0)
&gt; +{ /* Nothing to do. */ }
&gt; +
&gt; +template&lt;typename TreeType, typename RuleType&gt;
&gt; +void GreedySingleTreeTraverser&lt;TreeType, RuleType&gt;::Traverse(
&gt; +    const size_t queryIndex,
&gt; +    TreeType&amp; referenceNode)
&gt; +{
&gt; +  // If we have reached a leaf node, run the base case as necessary.
&gt; +  if (referenceNode.IsLeaf())
&gt; +  {
&gt; +    for (size_t i = 0; i &lt; referenceNode.NumPoints(); ++i)
&gt; +      rule.BaseCase(queryIndex, referenceNode.Point(i));
&gt; +  }
</pre>
<p>I think we should do all base cases regardless of whether or not we are a leaf, since some nodes may hold points in non-leaf nodes. Of the trees we have implemented now I believe that only applies to the cover tree, but more may be implemented in the future that also have that property.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/762/files/0484cfda36ef33e7b8ca5db46b7360369af161cc#r75478487">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJ4bFFPRX9xE2nzQZmVsONTjOr0GapLnks5qhauQgaJpZM4JlKcS">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFMRb6Aamuz8iFDHHuMMTfSOpR3BCks5qhauQgaJpZM4JlKcS.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/mlpack/mlpack/pull/762/files/0484cfda36ef33e7b8ca5db46b7360369af161cc#r75478487"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/mlpack/mlpack","title":"mlpack/mlpack","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/mlpack/mlpack"}},"updates":{"snippets":[{"icon":"PERSON","message":"@rcurtin in #762: I think we should do all base cases regardless of whether or not we are a leaf, since some nodes may hold points in non-leaf nodes. Of the trees we have implemented now I believe that only applies to the cover tree, but more may be implemented in the future that also have that property."}],"action":{"name":"View Pull Request","url":"https://github.com/mlpack/mlpack/pull/762/files/0484cfda36ef33e7b8ca5db46b7360369af161cc#r75478487"}}}</script>