<p><a href="https://github.com/rcurtin" class="user-mention">@rcurtin</a> , Yeah, I think we have to wait until the refactoring of <code>SplitSpace</code>.<br>
If we modify the <code>BinarySpaceTree</code> to hold a <code>Hyperplane</code> instance, we will be able to efficiently estimate the nearest and furthest child as I do with SpillTrees in: <a href="https://github.com/MarcosPividori/mlpack/blob/greedy-traverser/src/mlpack/core/tree/spill_tree/spill_tree_impl.hpp#L333">https://github.com/MarcosPividori/mlpack/blob/greedy-traverser/src/mlpack/core/tree/spill_tree/spill_tree_impl.hpp#L333</a><br>
I think this is ready to be merged. </p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/762#issuecomment-241094087">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJ4bFCf9W0C9qqF7QuBU495hH2CuUadrks5qhfLPgaJpZM4JlKcS">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFPlkNJGYIkT7MhiWbJVmxZk0d2VKks5qhfLPgaJpZM4JlKcS.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/mlpack/mlpack/pull/762#issuecomment-241094087"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/mlpack/mlpack","title":"mlpack/mlpack","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/mlpack/mlpack"}},"updates":{"snippets":[{"icon":"PERSON","message":"@MarcosPividori in #762: @rcurtin , Yeah, I think we have to wait until the refactoring of `SplitSpace`.\r\nIf we modify the `BinarySpaceTree` to hold a `Hyperplane` instance, we will be able to efficiently estimate the nearest and furthest child as I do with SpillTrees in: https://github.com/MarcosPividori/mlpack/blob/greedy-traverser/src/mlpack/core/tree/spill_tree/spill_tree_impl.hpp#L333\r\nI think this is ready to be merged. "}],"action":{"name":"View Pull Request","url":"https://github.com/mlpack/mlpack/pull/762#issuecomment-241094087"}}}</script>