<p><a href="https://github.com/rcurtin" class="user-mention">@rcurtin</a> <br>
I moved into a new branch, and I didn't realize this would close the PR. The previous PR was <a href="https://github.com/mlpack/mlpack/pull/743" class="issue-link js-issue-link" data-url="https://github.com/mlpack/mlpack/issues/743" data-id="168193672" data-error-text="Failed to load issue title" data-permission-text="Issue title is private">#743</a>.<br>
At this point everything is ready to merge. The only problem is that many warnings are shown when compiling because many methods use the deprecated constructors, passing a pointer to the reference tree.<br>
It would take some time to update all that parts of the code.<br>
Thanks</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/mlpack/mlpack/pull/765'>https://github.com/mlpack/mlpack/pull/765</a></p>
<h4>Commit Summary</h4>
<ul>
<li>Documentation details.</li>
<li>Add move constructor for cover tree.</li>
<li>Update kfn test to use rvalue references.</li>
<li>Add support for rvalue references when setting a given reference tree in</li>
<li>Update knn test to use rvalue references.</li>
<li>Fix error in BinarySearchTree move constructor.</li>
<li>Add a new TreeTraits's member: HasDuplicatedPoints.</li>
<li>Add support for copying the reference tree in NeighborSearch class.</li>
<li>Properly set oldFromNewReferences when providing a custom reference tree.</li>
<li>Remove unnecessary friendship.</li>
<li>Update tests to set oldFromNewReferences.</li>
<li>Add DEPRECATED macro.</li>
<li>Mark constructor and Train() method taking a pointer to the reference Tree as deprecated.</li>
<li>Remove unnecessary forward declaration.</li>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/mlpack/mlpack/pull/765/files#diff-0">src/mlpack/core.hpp</a>
(1)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/mlpack/mlpack/pull/765/files#diff-1">src/mlpack/core/tree/binary_space_tree/binary_space_tree_impl.hpp</a>
(6)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/mlpack/mlpack/pull/765/files#diff-2">src/mlpack/core/tree/binary_space_tree/traits.hpp</a>
(8)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/mlpack/mlpack/pull/765/files#diff-3">src/mlpack/core/tree/cover_tree/cover_tree.hpp</a>
(8)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/mlpack/mlpack/pull/765/files#diff-4">src/mlpack/core/tree/cover_tree/cover_tree_impl.hpp</a>
(40)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/mlpack/mlpack/pull/765/files#diff-5">src/mlpack/core/tree/cover_tree/traits.hpp</a>
(6)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/mlpack/mlpack/pull/765/files#diff-6">src/mlpack/core/tree/rectangle_tree/traits.hpp</a>
(10)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/mlpack/mlpack/pull/765/files#diff-7">src/mlpack/core/tree/tree_traits.hpp</a>
(5)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/mlpack/mlpack/pull/765/files#diff-8">src/mlpack/core/util/CMakeLists.txt</a>
(1)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/mlpack/mlpack/pull/765/files#diff-9">src/mlpack/core/util/deprecated.hpp</a>
(19)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/mlpack/mlpack/pull/765/files#diff-10">src/mlpack/methods/neighbor_search/neighbor_search.hpp</a>
(127)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/mlpack/mlpack/pull/765/files#diff-11">src/mlpack/methods/neighbor_search/neighbor_search_impl.hpp</a>
(106)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/mlpack/mlpack/pull/765/files#diff-12">src/mlpack/methods/neighbor_search/ns_model_impl.hpp</a>
(16)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/mlpack/mlpack/pull/765/files#diff-13">src/mlpack/tests/akfn_test.cpp</a>
(10)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/mlpack/mlpack/pull/765/files#diff-14">src/mlpack/tests/aknn_test.cpp</a>
(13)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/mlpack/mlpack/pull/765/files#diff-15">src/mlpack/tests/kfn_test.cpp</a>
(487)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/mlpack/mlpack/pull/765/files#diff-16">src/mlpack/tests/knn_test.cpp</a>
(525)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/mlpack/mlpack/pull/765.patch'>https://github.com/mlpack/mlpack/pull/765.patch</a></li>
<li><a href='https://github.com/mlpack/mlpack/pull/765.diff'>https://github.com/mlpack/mlpack/pull/765.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/765">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJ4bFEQ-aUZLrzTxdjmCv_aEkP0PIqFaks5qhO8jgaJpZM4JoBeZ">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFBJpaRKtcenXalEV4BqGnfL1uZhBks5qhO8jgaJpZM4JoBeZ.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/mlpack/mlpack/pull/765"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/mlpack/mlpack","title":"mlpack/mlpack","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/mlpack/mlpack"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Use move semantics to set a given reference tree in NeighborSearch class. (#765)"}],"action":{"name":"View Pull Request","url":"https://github.com/mlpack/mlpack/pull/765"}}}</script>