<p>In <a href="https://github.com/mlpack/mlpack/pull/747#discussion_r75175168">src/mlpack/methods/neighbor_search/knn_main.cpp</a>:</p>
<pre style='color:#555'>> @@ -209,12 +245,6 @@ int main(int argc, char *argv[])
> Log::Info << "Loaded kNN model from '" << inputModelFile << "' (trained on "
> << knn.Dataset().n_rows << "x" << knn.Dataset().n_cols << " dataset)."
> << endl;
> -
> - // Adjust singleMode and naive if necessary.
> - knn.SingleMode() = CLI::HasParam("single_mode");
> - knn.Naive() = CLI::HasParam("naive");
> - knn.LeafSize() = size_t(lsInt);
> - knn.Epsilon() = epsilon;
</pre>
<p><a href="https://github.com/rcurtin" class="user-mention">@rcurtin</a><br>
I removed all that options because they are incorrect:</p>
<ul>
<li>For example if we save a model in <code>SingleMode</code>, and we reload that model with no extra option, it will set:</li>
</ul>
<pre><code> knn.SingleMode() = CLI::HasParam("single_mode") ; // false
knn.Naive() = CLI::HasParam("naive") ; // false
</code></pre>
<p>It will do <code>Dual Tree Search</code> instead of <code>Single Tree Search</code>.</p>
<ul>
<li>Also, if we set the <code>LeafSize()</code> to a different value, we need to call <code>BuildModel</code> again, to rebuild the reference tree.</li>
<li>Also, in the parameter specifications, it is mentioned that "--leaf_size" "--naive" and "--single_mode" would be ignored when providing an input model file. So, I wanted to be consistent with that comments.</li>
</ul>
<p>So, it is a bit difficult to properly update a given input model.<br>
For example, if users provide an input model file, without the options "--naive" and "--single_mode", does it means they don't want to modify the model or that they want to update it to do "dual tree search"?</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/747/files/fe090ee13c7cad79e2b7eb8b6690628ba3ead1ed#r75175168">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJ4bFDAJHUcbWvy6eQ1GemtZHI0C3GqAks5qg03HgaJpZM4JZzLU">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFHz3vf5TFn_oa7DudRYy7XazwnuQks5qg03HgaJpZM4JZzLU.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/mlpack/mlpack/pull/747/files/fe090ee13c7cad79e2b7eb8b6690628ba3ead1ed#r75175168"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/mlpack/mlpack","title":"mlpack/mlpack","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/mlpack/mlpack"}},"updates":{"snippets":[{"icon":"PERSON","message":"@MarcosPividori in #747: @rcurtin\r\nI removed all that options because they are incorrect:\r\n+ For example if we save a model in `SingleMode`, and we reload that model with no extra option, it will set:\r\n```\r\n knn.SingleMode() = CLI::HasParam(\"single_mode\") ; // false\r\n knn.Naive() = CLI::HasParam(\"naive\") ; // false\r\n```\r\n It will do `Dual Tree Search` instead of `Single Tree Search`.\r\n+ Also, if we set the `LeafSize()` to a different value, we need to call `BuildModel` again, to rebuild the reference tree.\r\n+ Also, in the parameter specifications, it is mentioned that \"--leaf_size\" \"--naive\" and \"--single_mode\" would be ignored when providing an input model file. So, I wanted to be consistent with that comments.\r\n\r\nSo, it is a bit difficult to properly update a given input model.\r\nFor example, if users provide an input model file, without the options \"--naive\" and \"--single_mode\", does it means they don't want to modify the model or that they want to update it to do \"dual tree search\"?"}],"action":{"name":"View Pull Request","url":"https://github.com/mlpack/mlpack/pull/747/files/fe090ee13c7cad79e2b7eb8b6690628ba3ead1ed#r75175168"}}}</script>