<p>In <a href="https://github.com/mlpack/mlpack/pull/726#discussion_r75231126">src/mlpack/core/tree/binary_space_tree/rp_tree_max_split_impl.hpp</a>:</p>
<pre style='color:#555'>> + RPTreeMeanSplit<BoundType, MatType>::GetRandomDirection(
> + splitInfo.direction);
> +
> + // Get the value according to which we will perform the split.
> + if (!GetSplitVal(data, begin, count, splitInfo.direction, splitInfo.splitVal))
> + return false;
> +
> + return true;
> +}
> +
> +template<typename BoundType, typename MatType>
> +typename MatType::elem_type RPTreeMaxSplit<BoundType, MatType>::
> +GetRandomDeviation(const MatType& data,
> + const size_t begin,
> + const size_t count,
> + const arma::Col<ElemType>& direction)
</pre>
<p>Ok, I can agree with that. But I will remove this function when I merge and add a comment why we are not using the paper's technique.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/726/files/ea66e5d17914460289974cc61f0669941edc2524#r75231126">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJ4bFLtY7cZbMTeMhTEnjX_yDZ69PQXOks5qg6UegaJpZM4JOuGE">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFBPXwlMHdm9q2DqzIfNwR2Xn-YeIks5qg6UegaJpZM4JOuGE.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/mlpack/mlpack/pull/726/files/ea66e5d17914460289974cc61f0669941edc2524#r75231126"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/mlpack/mlpack","title":"mlpack/mlpack","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/mlpack/mlpack"}},"updates":{"snippets":[{"icon":"PERSON","message":"@rcurtin in #726: Ok, I can agree with that. But I will remove this function when I merge and add a comment why we are not using the paper's technique."}],"action":{"name":"View Pull Request","url":"https://github.com/mlpack/mlpack/pull/726/files/ea66e5d17914460289974cc61f0669941edc2524#r75231126"}}}</script>