<p>In <a href="https://github.com/mlpack/mlpack/pull/726#discussion_r75222406">src/mlpack/core/tree/binary_space_tree/rp_tree_max_split.hpp</a>:</p>
<pre style='color:#555'>> + const size_t begin,
> + const size_t count,
> + SplitInfo& splitInfo);
> +
> + /**
> + * Indicates that a point should be assigned to the left subtree.
> + *
> + * @param point The point that is being assigned.
> + * @param splitInfo An information about the split.
> + */
> + template<typename VecType>
> + static bool AssignToLeftNode(
> + const VecType& point,
> + const SplitInfo& splitInfo)
> + {
> + return (arma::dot(point, splitInfo.direction) <= splitInfo.splitVal);
</pre>
<p>It's true, I think the theory is only valid for L2. I just wanted to point out the issue, that's all. I don't think there is anything we can easily do about it.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/726/files/ea66e5d17914460289974cc61f0669941edc2524#r75222406">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJ4bFA-vi4oWm4qRHDYz_eJSO4qP0uzzks5qg5EcgaJpZM4JOuGE">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFJEbMOoA-R0fKdt-SKCaPvdYjgOqks5qg5EcgaJpZM4JOuGE.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/mlpack/mlpack/pull/726/files/ea66e5d17914460289974cc61f0669941edc2524#r75222406"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/mlpack/mlpack","title":"mlpack/mlpack","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/mlpack/mlpack"}},"updates":{"snippets":[{"icon":"PERSON","message":"@rcurtin in #726: It's true, I think the theory is only valid for L2. I just wanted to point out the issue, that's all. I don't think there is anything we can easily do about it."}],"action":{"name":"View Pull Request","url":"https://github.com/mlpack/mlpack/pull/726/files/ea66e5d17914460289974cc61f0669941edc2524#r75222406"}}}</script>