<p>In <a href="https://github.com/mlpack/mlpack/pull/747#discussion_r75069814">src/mlpack/methods/neighbor_search/spill_search_rules_impl.hpp</a>:</p>
<pre style='color:#555'>&gt; +    // better, then take it.
&gt; +    if (SortPolicy::IsBetter(queryNode.Parent()-&gt;Stat().FirstBound(),
&gt; +        worstDistance))
&gt; +      worstDistance = queryNode.Parent()-&gt;Stat().FirstBound();
&gt; +  }
&gt; +
&gt; +  // Could the existing bounds be better?
&gt; +  if (SortPolicy::IsBetter(queryNode.Stat().FirstBound(), worstDistance))
&gt; +    worstDistance = queryNode.Stat().FirstBound();
&gt; +
&gt; +  // Cache bounds for later.
&gt; +  queryNode.Stat().FirstBound() = worstDistance;
&gt; +
&gt; +  worstDistance = SortPolicy::Relax(worstDistance, epsilon);
&gt; +
&gt; +  return worstDistance;
</pre>
<p><a href="https://github.com/rcurtin" class="user-mention">@rcurtin</a> I agree. I have removed the specialization of <code>NeighborSearchRules</code> for <code>SpillTrees</code> in: <a href="https://github.com/mlpack/mlpack/pull/747/commits/e4ce9be6795817f7ceebafc26dd2b24c38a356f9" class="commit-link"><tt>e4ce9be</tt></a> and <a href="https://github.com/mlpack/mlpack/pull/747/commits/2bad753ca4859b6b2067d60b4323dcab5438959e" class="commit-link"><tt>2bad753</tt></a>.</p>

<ul>
<li>I moved the specific <code>Score()</code> calculation on overlapping nodes to the <code>Defeatist Traversers</code>.</li>
<li>I defined a simple struct <code>IsSpillTree</code>, and use it inside <code>CalculateBound()</code>, to avoid considering <em>B_2</em> bound for <code>SpillTrees</code>.</li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/747/files/fe090ee13c7cad79e2b7eb8b6690628ba3ead1ed#r75069814">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJ4bFOiPm9UDA1Qi75pADjY4tg_rB5Wfks5qgq4AgaJpZM4JZzLU">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFLWgfK9qw8S2EQ0UE2hW4CUTyIqtks5qgq4AgaJpZM4JZzLU.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/mlpack/mlpack/pull/747/files/fe090ee13c7cad79e2b7eb8b6690628ba3ead1ed#r75069814"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/mlpack/mlpack","title":"mlpack/mlpack","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/mlpack/mlpack"}},"updates":{"snippets":[{"icon":"PERSON","message":"@MarcosPividori in #747: @rcurtin I agree. I have removed the specialization of `NeighborSearchRules` for `SpillTrees` in: https://github.com/mlpack/mlpack/pull/747/commits/e4ce9be6795817f7ceebafc26dd2b24c38a356f9 and https://github.com/mlpack/mlpack/pull/747/commits/2bad753ca4859b6b2067d60b4323dcab5438959e.\r\n+ I moved the specific `Score()` calculation on overlapping nodes to the `Defeatist Traversers`.\r\n+ I defined a simple struct `IsSpillTree`, and use it inside `CalculateBound()`, to avoid considering *B_2* bound for `SpillTrees`."}],"action":{"name":"View Pull Request","url":"https://github.com/mlpack/mlpack/pull/747/files/fe090ee13c7cad79e2b7eb8b6690628ba3ead1ed#r75069814"}}}</script>