<p>In <a href="https://github.com/mlpack/mlpack/pull/747#discussion_r75050155">src/mlpack/methods/neighbor_search/spill_search_rules_impl.hpp</a>:</p>
<pre style='color:#555'>&gt; +    // better, then take it.
&gt; +    if (SortPolicy::IsBetter(queryNode.Parent()-&gt;Stat().FirstBound(),
&gt; +        worstDistance))
&gt; +      worstDistance = queryNode.Parent()-&gt;Stat().FirstBound();
&gt; +  }
&gt; +
&gt; +  // Could the existing bounds be better?
&gt; +  if (SortPolicy::IsBetter(queryNode.Stat().FirstBound(), worstDistance))
&gt; +    worstDistance = queryNode.Stat().FirstBound();
&gt; +
&gt; +  // Cache bounds for later.
&gt; +  queryNode.Stat().FirstBound() = worstDistance;
&gt; +
&gt; +  worstDistance = SortPolicy::Relax(worstDistance, epsilon);
&gt; +
&gt; +  return worstDistance;
</pre>
<p><a href="https://github.com/rcurtin" class="user-mention">@rcurtin</a> , The <code>Score()</code> calculation is different too, because I consider the special case of overlapping nodes. As there are 3 different methods, I thought it would preferable to have a different implementation, but I agree this means some duplicated code. I was not sure what was preferable, some duplicated code with the advantage of not modifying the original search rules, or more compact code but a bit more complex.</p>

<p>As I have to access the <code>Overlap()</code> method of Spill Trees and it is not included in all tree types, I can't use the <code>#ifdef</code> approach, because we will have a compiler error when instantiating with a different tree type. I think I should consider template specialization for the Score() methods.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/747/files/fe090ee13c7cad79e2b7eb8b6690628ba3ead1ed#r75050155">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJ4bFMv1qtKTWaXumIAN1D36M8JQ5oNXks5qgmMWgaJpZM4JZzLU">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFC4u0ArXUtQ59rxcT80ZXZXrsSTpks5qgmMWgaJpZM4JZzLU.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/mlpack/mlpack/pull/747/files/fe090ee13c7cad79e2b7eb8b6690628ba3ead1ed#r75050155"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/mlpack/mlpack","title":"mlpack/mlpack","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/mlpack/mlpack"}},"updates":{"snippets":[{"icon":"PERSON","message":"@MarcosPividori in #747: @rcurtin , The `Score()` calculation is different too, because I consider the special case of overlapping nodes. As there are 3 different methods, I thought it would preferable to have a different implementation, but I agree this means some duplicated code. I was not sure what was preferable, some duplicated code with the advantage of not modifying the original search rules, or more compact code but a bit more complex.\r\n\r\nAs I have to access the `Overlap()` method of Spill Trees and it is not included in all tree types, I can't use the `#ifdef` approach, because we will have a compiler error when instantiating with a different tree type. I think I should consider template specialization for the Score() methods."}],"action":{"name":"View Pull Request","url":"https://github.com/mlpack/mlpack/pull/747/files/fe090ee13c7cad79e2b7eb8b6690628ba3ead1ed#r75050155"}}}</script>