<p>In <a href="https://github.com/mlpack/mlpack/pull/747#discussion_r75070381">src/mlpack/core/tree/spill_tree/single_tree_traverser.hpp</a>:</p>
<pre style='color:#555'>&gt; +#include &lt;mlpack/core.hpp&gt;
&gt; +
&gt; +#include &quot;spill_tree.hpp&quot;
&gt; +
&gt; +namespace mlpack {
&gt; +namespace tree {
&gt; +
&gt; +template&lt;typename MetricType,
&gt; +         typename StatisticType,
&gt; +         typename MatType,
&gt; +         template&lt;typename HyperplaneMetricType&gt; class HyperplaneType,
&gt; +         template&lt;typename SplitMetricType, typename SplitMatType&gt;
&gt; +             class SplitType&gt;
&gt; +template&lt;typename RuleType&gt;
&gt; +class SpillTree&lt;MetricType, StatisticType, MatType, HyperplaneType, SplitType&gt;::
&gt; +    SingleTreeTraverser
</pre>
<p>Hi <a href="https://github.com/rcurtin" class="user-mention">@rcurtin</a>,<br>
Thanks for your comments, I agree!<br>
I have modified the SpillTree's Traversers. Now they take a template boolean parameter <code>Defeatist</code>, that determines if the traverser must consider defeatist search on overlapping nodes. In the commits:<br>
<a href="https://github.com/mlpack/mlpack/pull/747/commits/0267acb46caef51370e737cf253a1664ea7be263" class="commit-link"><tt>0267acb</tt></a><br>
<a href="https://github.com/mlpack/mlpack/pull/747/commits/70fbeab1e0be29113f0e21c688601133c23d4751" class="commit-link"><tt>70fbeab</tt></a><br>
<a href="https://github.com/mlpack/mlpack/pull/747/commits/b334674a12817b3e4b3f37ac6f99eb52bfd3e44c" class="commit-link"><tt>b334674</tt></a></p>

<p>So, for <code>SpillTrees</code>, I provide 4 tree traversers:<br>
+<code>SingleTreeTraverser</code>   implements a normal single tree traverser.<br>
+<code>DualTreeTraverser</code>   implements a normal dual tree traverser.<br>
+<code>DefeatistSingleTreeTraverser</code>   does defeatist search on overlapping nodes.<br>
+<code>DefeatistDualTreeTraverser</code>   does defeatist serach on overlapping node.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/747/files/fe090ee13c7cad79e2b7eb8b6690628ba3ead1ed#r75070381">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJ4bFJ4nJnf3bgkaJKl09c2iksLK6wgXks5qgq-CgaJpZM4JZzLU">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFIu_AaMuFkPgt4eFLJHI6yCBJExYks5qgq-CgaJpZM4JZzLU.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/mlpack/mlpack/pull/747/files/fe090ee13c7cad79e2b7eb8b6690628ba3ead1ed#r75070381"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/mlpack/mlpack","title":"mlpack/mlpack","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/mlpack/mlpack"}},"updates":{"snippets":[{"icon":"PERSON","message":"@MarcosPividori in #747: Hi @rcurtin,\r\nThanks for your comments, I agree!\r\nI have modified the SpillTree's Traversers. Now they take a template boolean parameter `Defeatist`, that determines if the traverser must consider defeatist search on overlapping nodes. In the commits:\r\nhttps://github.com/mlpack/mlpack/pull/747/commits/0267acb46caef51370e737cf253a1664ea7be263\r\nhttps://github.com/mlpack/mlpack/pull/747/commits/70fbeab1e0be29113f0e21c688601133c23d4751\r\nhttps://github.com/mlpack/mlpack/pull/747/commits/b334674a12817b3e4b3f37ac6f99eb52bfd3e44c\r\n\r\nSo, for `SpillTrees`, I provide 4 tree traversers:\r\n+`SingleTreeTraverser`   implements a normal single tree traverser.\r\n+`DualTreeTraverser`   implements a normal dual tree traverser.\r\n+`DefeatistSingleTreeTraverser`   does defeatist search on overlapping nodes.\r\n+`DefeatistDualTreeTraverser`   does defeatist serach on overlapping node."}],"action":{"name":"View Pull Request","url":"https://github.com/mlpack/mlpack/pull/747/files/fe090ee13c7cad79e2b7eb8b6690628ba3ead1ed#r75070381"}}}</script>