<p>In <a href="https://github.com/mlpack/mlpack/pull/747#discussion_r74704606">src/mlpack/methods/neighbor_search/knn_main.cpp</a>:</p>
<pre style='color:#555'>> @@ -78,6 +82,9 @@ PARAM_FLAG("single_mode", "If true, single-tree search is used (as opposed to "
> "dual-tree search).", "S");
> PARAM_DOUBLE_IN("epsilon", "If specified, will do approximate nearest neighbor "
> "search with given relative error.", "e", 0);
> +PARAM_STRING_IN("effective_error", "If specified, will compare the results "
> + "against the provided distances file, and will print the average relative "
> + "error.", "E", "");
</pre>
<p>I think we should name this similarly to the parameter to do this for LSH:</p>
<pre><code>// For testing recall.
PARAM_STRING_IN("true_neighbors_file", "File of true neighbors to compute "
"recall with (the recall is printed when -v is specified).", "t", "");
</code></pre>
<p>In this case you're calculating and printing a slightly different comment, so you'll have to update the comments a bit. I think you'll need <code>true_distances_file</code> instead, and the short option will need to be <code>-T</code> since <code>-t</code> is already taken.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/747/files/fe090ee13c7cad79e2b7eb8b6690628ba3ead1ed#r74704606">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJ4bFLfX6oMw__gi-RkLS41ab2V1Kp6kks5qf0CkgaJpZM4JZzLU">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFC2UnajeSHSN5FOt6yFJLYO7gzu3ks5qf0CkgaJpZM4JZzLU.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/mlpack/mlpack/pull/747/files/fe090ee13c7cad79e2b7eb8b6690628ba3ead1ed#r74704606"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/mlpack/mlpack","title":"mlpack/mlpack","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/mlpack/mlpack"}},"updates":{"snippets":[{"icon":"PERSON","message":"@rcurtin in #747: I think we should name this similarly to the parameter to do this for LSH:\r\n\r\n```\r\n// For testing recall.\r\nPARAM_STRING_IN(\"true_neighbors_file\", \"File of true neighbors to compute \"\r\n \"recall with (the recall is printed when -v is specified).\", \"t\", \"\");\r\n```\r\n\r\nIn this case you're calculating and printing a slightly different comment, so you'll have to update the comments a bit. I think you'll need `true_distances_file` instead, and the short option will need to be `-T` since `-t` is already taken."}],"action":{"name":"View Pull Request","url":"https://github.com/mlpack/mlpack/pull/747/files/fe090ee13c7cad79e2b7eb8b6690628ba3ead1ed#r74704606"}}}</script>