<p>In <a href="https://github.com/mlpack/mlpack/pull/747#discussion_r74704358">src/mlpack/core/tree/spill_tree/spill_tree_impl.hpp</a>:</p>
<pre style='color:#555'>> + }
> +
> + std::vector<size_t> leftPoints, rightPoints;
> + // Split the node.
> + overlappingNode = SplitPoints(tau, rho, points, leftPoints, rightPoints);
> +
> + // We don't need the information in points, so lets clean it.
> + std::vector<size_t>().swap(points);
> +
> + // Now we will recursively split the children by calling their constructors
> + // (which perform this splitting process).
> + left = new SpillTree(this, leftPoints, tau, maxLeafSize, rho);
> + right = new SpillTree(this, rightPoints, tau, maxLeafSize, rho);
> +
> + // Update count number, to represent the number of descendant points.
> + count = left->NumDescendants() + right->NumDescendants();
</pre>
<p>Ok, that looks good to me. We do also have to handle <code>RangeSearchRules</code>, which will prune in some situations and add all descendant points to the results. We can either add some handling in <code>RangeSearchRules::AddResult()</code> to handle when <code>UniqueNumDescendants</code> is false and avoid adding any duplicate points, or we can add a static assert to <code>RangeSearch</code> like you did for <code>RASearch</code>. Your call, I think either way is easy enough to do.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/747/files/a71b57caa90311f5542180bc0553449c3691395d#r74704358">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJ4bFHw6Y31pwb8rcisWn2vAKvlMF6eSks5qfzybgaJpZM4JZzLU">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFJMmF4U_JpbjQZ7j3XUPC3GtkGqpks5qfzybgaJpZM4JZzLU.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/mlpack/mlpack/pull/747/files/a71b57caa90311f5542180bc0553449c3691395d#r74704358"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/mlpack/mlpack","title":"mlpack/mlpack","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/mlpack/mlpack"}},"updates":{"snippets":[{"icon":"PERSON","message":"@rcurtin in #747: Ok, that looks good to me. We do also have to handle `RangeSearchRules`, which will prune in some situations and add all descendant points to the results. We can either add some handling in `RangeSearchRules::AddResult()` to handle when `UniqueNumDescendants` is false and avoid adding any duplicate points, or we can add a static assert to `RangeSearch` like you did for `RASearch`. Your call, I think either way is easy enough to do."}],"action":{"name":"View Pull Request","url":"https://github.com/mlpack/mlpack/pull/747/files/a71b57caa90311f5542180bc0553449c3691395d#r74704358"}}}</script>