<p>In <a href="https://github.com/mlpack/mlpack/pull/747#discussion_r74708201">src/mlpack/methods/neighbor_search/spill_search_rules_impl.hpp</a>:</p>
<pre style='color:#555'>> + // better, then take it.
> + if (SortPolicy::IsBetter(queryNode.Parent()->Stat().FirstBound(),
> + worstDistance))
> + worstDistance = queryNode.Parent()->Stat().FirstBound();
> + }
> +
> + // Could the existing bounds be better?
> + if (SortPolicy::IsBetter(queryNode.Stat().FirstBound(), worstDistance))
> + worstDistance = queryNode.Stat().FirstBound();
> +
> + // Cache bounds for later.
> + queryNode.Stat().FirstBound() = worstDistance;
> +
> + worstDistance = SortPolicy::Relax(worstDistance, epsilon);
> +
> + return worstDistance;
</pre>
<p>I believe that <code>CalculateBound()</code> is the only function that needs to be changed in the rules class; is that right? Maybe it is better to use some standalone static method to calculate the bound for spill trees, and then something like this in <code>NeighborSearchRules::CalculateBound()</code>:</p>
<pre><code>if (IsSpillTree<TreeType>::value)
return CalculateSpillBound(queryNode);
</code></pre>
<p>If there are other things that differ in this class, too, it might be necessary to use this same trick there. I see this kind of as a variant of the <code>#ifdef</code> style of making things compatible, so it's kind of hackish, but I think maybe it is better than replicating the entire class in order to change only a little functionality. What do you think?</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/747/files/fe090ee13c7cad79e2b7eb8b6690628ba3ead1ed#r74708201">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJ4bFHlhjod_Jl1zFyOsD9_8OPNp2oFfks5qf3-FgaJpZM4JZzLU">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFJm7u7BZaWmjcrs2Gma0wm7wv9Kyks5qf3-FgaJpZM4JZzLU.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/mlpack/mlpack/pull/747/files/fe090ee13c7cad79e2b7eb8b6690628ba3ead1ed#r74708201"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/mlpack/mlpack","title":"mlpack/mlpack","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/mlpack/mlpack"}},"updates":{"snippets":[{"icon":"PERSON","message":"@rcurtin in #747: I believe that `CalculateBound()` is the only function that needs to be changed in the rules class; is that right? Maybe it is better to use some standalone static method to calculate the bound for spill trees, and then something like this in `NeighborSearchRules::CalculateBound()`:\r\n\r\n```\r\nif (IsSpillTree\u003cTreeType\u003e::value)\r\n return CalculateSpillBound(queryNode);\r\n```\r\n\r\nIf there are other things that differ in this class, too, it might be necessary to use this same trick there. I see this kind of as a variant of the `#ifdef` style of making things compatible, so it's kind of hackish, but I think maybe it is better than replicating the entire class in order to change only a little functionality. What do you think?"}],"action":{"name":"View Pull Request","url":"https://github.com/mlpack/mlpack/pull/747/files/fe090ee13c7cad79e2b7eb8b6690628ba3ead1ed#r74708201"}}}</script>