<p>In <a href="https://github.com/mlpack/mlpack/pull/703#discussion_r74704141">src/mlpack/tests/edge_boxes_test.cpp</a>:</p>
<pre style='color:#555'>> +
> + CubeType PDist(CubeType& features, arma::uvec& grid_pos);
> + ***-/
> +*/
> +
> +BOOST_AUTO_TEST_SUITE(EdgeBoxesTest);
> +
> +/**
> + * This test checks the feature extraction functions
> + * mentioned in feature_extraction.hpp
> + */
> +
> +void Test(arma::mat m1, arma::mat m2)
> +{
> + for (size_t i = 0; i < m1.n_cols; ++i)
> + BOOST_REQUIRE_CLOSE(m1(i), m2(i), 1e-2);
</pre>
<p>That only compares the first (n_cols) elements. I think you like to use n_elem. Also you could use a template parameter for the mat type and just write a single function for cube and mat.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/703/files/72eb1ef22c7db1ea33af3de1cd043cdb277ec562#r74704141">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJ4bFAOwe6vua6RQ_3HQvpCsmmhiynYPks5qfzlUgaJpZM4I5X__">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFLIkux7HmSsEs-hhrIIUOgEiPTisks5qfzlUgaJpZM4I5X__.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/mlpack/mlpack/pull/703/files/72eb1ef22c7db1ea33af3de1cd043cdb277ec562#r74704141"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/mlpack/mlpack","title":"mlpack/mlpack","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/mlpack/mlpack"}},"updates":{"snippets":[{"icon":"PERSON","message":"@zoq in #703: That only compares the first (n_cols) elements. I think you like to use n_elem. Also you could use a template parameter for the mat type and just write a single function for cube and mat."}],"action":{"name":"View Pull Request","url":"https://github.com/mlpack/mlpack/pull/703/files/72eb1ef22c7db1ea33af3de1cd043cdb277ec562#r74704141"}}}</script>