<p>In <a href="https://github.com/mlpack/mlpack/pull/703#discussion_r74704163">src/mlpack/methods/edge_boxes/feature_extraction_impl.hpp</a>:</p>
<pre style='color:#555'>&gt; +    this-&gt;ConvTriangle(Img, grdSmoothRad); 
&gt; +    MatType Magnitude(InImage.n_rows, InImage.n_cols),
&gt; +             Orientation(InImage.n_rows, InImage.n_cols);
&gt; +    
&gt; +    this-&gt;Gradient(Img, Magnitude, Orientation);
&gt; +    size_t downscale = std::max(1, (int)(shrink * scale));
&gt; +    
&gt; +    CubeType Hist;
&gt; +    this-&gt;Histogram(Magnitude, Orientation,
&gt; +                    downscale, 0, Hist);
&gt; +    BilinearInterpolation( Magnitude, rsize, csize, channels.slice(slice_idx));
&gt; +    slice_idx++;
&gt; +    for(size_t i = 0; i &lt; InImage.n_slices; ++i)
&gt; +      BilinearInterpolation( Magnitude, rsize, csize,
&gt; +                      channels.slice(i + slice_idx));    
&gt; +    slice_idx += 3;
</pre>
<p>I would recommend to use slice_idx += n_slicesinstead of slice_idx += 3; there is no guarantee that we call the function with a 3 channel image.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/703/files/72eb1ef22c7db1ea33af3de1cd043cdb277ec562#r74704163">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJ4bFOAG41kzG0Vwn3WgyGxUFShRV-wMks5qfzmbgaJpZM4I5X__">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFEvpHpPDfALdgicT7HBg0ER6mm2Gks5qfzmbgaJpZM4I5X__.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/mlpack/mlpack/pull/703/files/72eb1ef22c7db1ea33af3de1cd043cdb277ec562#r74704163"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/mlpack/mlpack","title":"mlpack/mlpack","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/mlpack/mlpack"}},"updates":{"snippets":[{"icon":"PERSON","message":"@zoq in #703: I would recommend to use slice_idx += n_slicesinstead of slice_idx += 3; there is no guarantee that we call the function with a 3 channel image."}],"action":{"name":"View Pull Request","url":"https://github.com/mlpack/mlpack/pull/703/files/72eb1ef22c7db1ea33af3de1cd043cdb277ec562#r74704163"}}}</script>