<p>In <a href="https://github.com/mlpack/mlpack/pull/747#discussion_r74709361">src/mlpack/tests/spill_tree_test.cpp</a>:</p>
<pre style='color:#555'>> +
> +/**
> + * Simple test for the move constructor.
> + */
> +BOOST_AUTO_TEST_CASE(SpillTreeMoveDatasetTest)
> +{
> + arma::mat dataset = arma::randu<arma::mat>(3, 1000);
> + typedef SPTree<EuclideanDistance, EmptyStatistic, arma::mat> TreeType;
> +
> + TreeType tree(std::move(dataset));
> +
> + BOOST_REQUIRE_EQUAL(dataset.n_elem, 0);
> + BOOST_REQUIRE_EQUAL(tree.Dataset().n_rows, 3);
> + BOOST_REQUIRE_EQUAL(tree.Dataset().n_cols, 1000);
> +}
> +
</pre>
<p>Should we also test the copy constructor? You could do this:</p>
<pre><code>TreeType t = new TreeType(dataset);
TreeType t2(t);
delete t;
// Now check that everything is still valid.
</code></pre>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/mlpack/mlpack/pull/747/files/fe090ee13c7cad79e2b7eb8b6690628ba3ead1ed#r74709361">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AJ4bFCfO32kfgu3i7bIxapjwtc90S-wWks5qf49SgaJpZM4JZzLU">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AJ4bFE8TM5REf3XFIns3CIa9rInauDYlks5qf49SgaJpZM4JZzLU.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/mlpack/mlpack/pull/747/files/fe090ee13c7cad79e2b7eb8b6690628ba3ead1ed#r74709361"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/mlpack/mlpack","title":"mlpack/mlpack","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/mlpack/mlpack"}},"updates":{"snippets":[{"icon":"PERSON","message":"@rcurtin in #747: Should we also test the copy constructor? You could do this:\r\n\r\n```\r\nTreeType t = new TreeType(dataset);\r\nTreeType t2(t);\r\ndelete t;\r\n\r\n// Now check that everything is still valid.\r\n``` "}],"action":{"name":"View Pull Request","url":"https://github.com/mlpack/mlpack/pull/747/files/fe090ee13c7cad79e2b7eb8b6690628ba3ead1ed#r74709361"}}}</script>